This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Applied several hacks to make sipml5 more stable #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roginvs
commented
Jan 16, 2017
roginvs
commented
- ICE Gathering timeout hack: This solves a problem when calls can delay up to 10 seconds. It happens when some of stun requests are dropped, for example if they are sent from interface without internet and etc.
- Failed to set local answer sdp: In some cases sipml5 can cause this error in Chrome. Workaround is taken from https://code.google.com/archive/p/sipml5/issues/209 with a simple change to make hold/resume working again.
- Fix for CallerId Name problems from Caller ID Name Not Present on Incoming Call to sipML5 #163
- Indication for "Call completed elsewhere". Just simple lookup for such reason. This is useful in order to not to show such calls as missed
…te: STATE_INPROGRESS" as described in https://code.google.com/p/sipml5/issues/detail?id=209
… then sipml5 will send "terminated" event with "Call completed elsewhere" in event description
|
Will you also fix the issue with new chrome? |
|
@vferko , thanks, Chrome 57 could be a surprise for us. Fixed in 4e4b728 |
roginvs
force-pushed
the
patches-to-origin
branch
from
4e4b728 to
15792cf
Compare
Conflicts: release/SIPml-api.js
|
Hi @roginvs. I've tried the code from your repo https://github.com/roginvs/sipml5/commits/patches-to-origin and from the doubango master https://github.com/DoubangoTelecom/sipml5/commits/master. I'm not sure what I've done wrong. Scenario: The cause seems to be the busy status: Do you need all the debug messages ? If I make a call to an external mobile phone, the call is ok, but when I answer no audio is present. (With current Chrome 56 stable all work correctly.) Could you give me some tips ? |
|
@alepolidori , I have same Chrome version [57.0.2987.37 beta (64-bit)], but on Windows 10, and it works. |
|
@roginvs Following is the log of call using both chrome beta CALL phase: |
|
And what about the opposite peer? Logs on this side does not shows anything :( |
|
I try to recap by providing more detailed info to avoid confusion. Test 1 using "master" of "Doubango"
Test 2 using "patches_to_origin" of "roginvs"
As you can see the error seems to be the lack of "a=rtcp-mux" into the called extension. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.