[CI] Restore release assets #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
force-pushed
the
feature/restore-release-assets
branch
from
7c51d38
to
8b5b191
Compare
.github/workflows/main.yml
Outdated
| @@ -1,7 +1,5 @@ | |||
| name: OctoBot-Binary-CI | |||
| on: | |||
| schedule: | |||
| - cron: '0 5 * * 1' # every monday at 5am | |||
There was a problem hiding this comment.
why removing the cron job ?
There was a problem hiding this comment.
Because it cannot be used anymore if we don't push to an external storage.
Otherwise, we can build it for fun.
There was a problem hiding this comment.
the idea is also to check that builds keep working, I think we should keep it and not upload binaries
How would you like me to have tested it? It's not possible without releasing :/ |
right :/ |
Herklos
force-pushed
the
feature/restore-release-assets
branch
from
8b5b191
to
e0f5690
Compare
GuillaumeDSM
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.