add MinimumOrderCostNotReachedError and minor fixes #803
Conversation
octobot_trading/api/exchange.py
Outdated
| import octobot_trading.exchanges.connectors.ccxt.enums | ||
| import octobot_trading.exchanges.connectors.ccxt.enums as ccxt_enums | ||
| import octobot_trading.exchanges as exchanges | ||
| import octobot_trading.exchanges.exchange_builder as exchange_builder |
There was a problem hiding this comment.
The import philosophy is to import high level module (exchanges, personal_data) when not importing from within the module. The idea here is to prevent changing all imports when we update internal module architecture
There was a problem hiding this comment.
ah okay, I removed those changes
octobot_trading/errors.py
Outdated
| """ | ||
|
|
||
|
|
||
| class MinimumOrderCostNotReachedError(Exception): |
There was a problem hiding this comment.
I don't really understand why we need both MinimumOrderCostNotReachedError and MissingMinimalExchangeTradeVolume. MissingMinimalExchangeTradeVolume is not doing the same thing ? Should we raise it where you are raising MinimumOrderCostNotReachedError or you need another exception ?
There was a problem hiding this comment.
I changed it so its using MissingMinimalExchangeTradeVolume, didnt notice that one
| enums.ExchangeConstantsMarketPropertyColumns.TAKER.value: | ||
| market_status.get(enums.ExchangeConstantsMarketPropertyColumns.TAKER.value, | ||
| constants.CONFIG_DEFAULT_FEES), | ||
| ) or constants.CONFIG_DEFAULT_FEES, |
There was a problem hiding this comment.
When market_status[ExchangeConstantsMarketPropertyColumns.TAKER.value], market_status[ExchangeConstantsMarketPropertyColumns.MAKER.value] or market_status[ExchangeConstantsMarketPropertyColumns.FEE.value] is None, it will now properly use the fallback fees. Before my changes it would set them to None
| if not personal_data.check_cost(float(total_order_price), min_cost): | ||
| return [] | ||
| symbol = f"{symbol_market['symbol']} - " if 'symbol' in symbol_market else "" | ||
| raise errors.MinimumOrderCostNotReachedError( |
There was a problem hiding this comment.
Then it should be catch if necessary everywhere this method is called
There was a problem hiding this comment.
I added exceptions, also in the PR in octobot tentacles -> [Order] handle MinimumOrderCostNotReachedError
| return side, parsed_order_type | ||
| except (KeyError, ValueError): | ||
| return None, None | ||
| return side, enums.TraderOrderType.UNKNOWN |
There was a problem hiding this comment.
Was an accident, I removed it
techfreaque
force-pushed
the
minor_changes
branch
2 times, most recently
from
3f15e66 to
f8f66a4
Compare
techfreaque
force-pushed
the
minor_changes
branch
from
f8f66a4 to
15b91f8
Compare
techfreaque
force-pushed
the
minor_changes
branch
from
15b91f8 to
18f12ce
Compare
techfreaque
force-pushed
the
minor_changes
branch
from
18f12ce to
134e5c6
Compare
|
to reopen of relevant |
3 participants
properly handle MissingMinimalExchangeTradeVolume