add MinimumOrderCostNotReachedError and minor fixes #803

techfreaque · 2023-01-15T21:35:42Z

properly handle MissingMinimalExchangeTradeVolume

Herklos · 2023-01-16T07:05:50Z

octobot_trading/api/exchange.py

 import octobot_trading.exchanges as exchanges
+import octobot_trading.exchanges.exchange_builder as exchange_builder


The import philosophy is to import high level module (exchanges, personal_data) when not importing from within the module. The idea here is to prevent changing all imports when we update internal module architecture

ah okay, I removed those changes

Herklos · 2023-01-16T07:06:06Z

octobot_trading/errors.py

@@ -21,6 +21,12 @@ class MissingFunds(Exception):
    """


+class MinimumOrderCostNotReachedError(Exception):


I don't really understand why we need both MinimumOrderCostNotReachedError and MissingMinimalExchangeTradeVolume. MissingMinimalExchangeTradeVolume is not doing the same thing ? Should we raise it where you are raising MinimumOrderCostNotReachedError or you need another exception ?

I changed it so its using MissingMinimalExchangeTradeVolume, didnt notice that one

Herklos · 2023-01-16T07:07:10Z

octobot_trading/exchanges/connectors/ccxt/ccxt_connector.py

@@ -497,13 +497,13 @@ def get_fees(self, symbol):
            return {
                enums.ExchangeConstantsMarketPropertyColumns.TAKER.value:
                    market_status.get(enums.ExchangeConstantsMarketPropertyColumns.TAKER.value,
-                                      constants.CONFIG_DEFAULT_FEES),
+                                      ) or constants.CONFIG_DEFAULT_FEES,


When market_status[ExchangeConstantsMarketPropertyColumns.TAKER.value], market_status[ExchangeConstantsMarketPropertyColumns.MAKER.value] or market_status[ExchangeConstantsMarketPropertyColumns.FEE.value] is None, it will now properly use the fallback fees. Before my changes it would set them to None

Herklos · 2023-01-16T07:08:01Z

octobot_trading/personal_data/orders/decimal_order_adapter.py

@@ -188,7 +188,11 @@ def decimal_check_and_adapt_order_details_if_necessary(quantity, price, symbol_m

            # check total_order_price not < min_cost
            if not personal_data.check_cost(float(total_order_price), min_cost):
-                return []
+                symbol = f"{symbol_market['symbol']} - " if 'symbol' in symbol_market else ""
+                raise errors.MinimumOrderCostNotReachedError(


Then it should be catch if necessary everywhere this method is called

I added exceptions, also in the PR in octobot tentacles -> [Order] handle MinimumOrderCostNotReachedError

Herklos · 2023-01-16T07:08:13Z

octobot_trading/personal_data/orders/order.py

@@ -714,7 +714,7 @@ def parse_order_type(raw_order):
                parsed_order_type = _get_sell_and_buy_types(order_type)
        return side, parsed_order_type
    except (KeyError, ValueError):
-        return None, None
+        return side, enums.TraderOrderType.UNKNOWN


Was an accident, I removed it

Herklos reviewed Jan 16, 2023

View reviewed changes

techfreaque force-pushed the minor_changes branch 2 times, most recently from 3f15e66 to f8f66a4 Compare January 20, 2023 14:20

techfreaque force-pushed the minor_changes branch from f8f66a4 to 15b91f8 Compare January 28, 2023 11:26

Herklos assigned GuillaumeDSM and Herklos Jan 28, 2023

Herklos requested review from Herklos and GuillaumeDSM January 28, 2023 11:45

techfreaque force-pushed the minor_changes branch from 15b91f8 to 18f12ce Compare February 10, 2023 19:14

techfreaque added 2 commits February 16, 2023 15:41

[CCXTConnector] make fall back fees work properly

ed3cda5

[Orders] handle MissingMinimalExchangeTradeVolume

134e5c6

techfreaque force-pushed the minor_changes branch from 18f12ce to 134e5c6 Compare February 16, 2023 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add MinimumOrderCostNotReachedError and minor fixes #803

add MinimumOrderCostNotReachedError and minor fixes #803

techfreaque commented Jan 15, 2023 •

edited

Loading

Herklos Jan 16, 2023

techfreaque Jan 16, 2023

Herklos Jan 16, 2023

GuillaumeDSM Feb 10, 2023

techfreaque Feb 10, 2023

Herklos Jan 16, 2023

techfreaque Jan 16, 2023

Herklos Jan 16, 2023

techfreaque Jan 16, 2023

Herklos Jan 16, 2023

techfreaque Jan 16, 2023

		import octobot_trading.exchanges as exchanges
		import octobot_trading.exchanges.exchange_builder as exchange_builder

		@@ -21,6 +21,12 @@ class MissingFunds(Exception):
		"""


		class MinimumOrderCostNotReachedError(Exception):

add MinimumOrderCostNotReachedError and minor fixes #803

Are you sure you want to change the base?

add MinimumOrderCostNotReachedError and minor fixes #803

Conversation

techfreaque commented Jan 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

techfreaque commented Jan 15, 2023 •

edited

Loading