fix trading mode init #1177
Merged
fix trading mode init #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the goal of this PR |
Trading modes advanced classes are initialized in exchange_builder now, that's an issue because if 2 or more exchanges are created, advanced classes are duplicated also. Trading mode advanced classes should be managed independently from exchange creation |
Ok I understand. Can we move that to the Tentacle Manager ? |
Herklos
approved these changes
May 14, 2020
GuillaumeDSM
force-pushed
the
multiple_fixes
branch
from
6ca4ae6
to
0fbc61d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires Drakkar-Software/OctoBot-Trading#196