Doc(clientVariableScopes): Experimental annotations for clientVariableScopes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicaldave
added
documentation
…d removed redundant docs
…s into doc/annotations-clientVariableScopes
|
This one is ready, I think. 👍 |
|
It seems to be a mix of working and not working for me, my editor isn't liking the ? for some of the declarations, but the functions themselves look fine, though i wonder how much use this would end up being with all these annotations
|
… name instead of type name
…ame in clientvariablescopes
|
Would appreciate an additional chime on this one as stylistically I don't like placing the |
HotaruBlaze
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These ones I'm less confident in, I couldn't quite pin down how to document the table. I'm posting this one as a draft PR for review.
#15