Skip to content

Implement Entity HIR structure #541

Implement Entity HIR structure

Implement Entity HIR structure #541

Triggered via pull request September 13, 2023 01:55
Status Success
Total duration 8m 10s
Artifacts

rust.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

1 error and 24 warnings
incorrect implementation of `clone` on a `Copy` type: compiler/toc-hir-expand/src/lib.rs#L75
error: incorrect implementation of `clone` on a `Copy` type --> compiler/toc-hir-expand/src/lib.rs:75:29 | 75 | fn clone(&self) -> Self { | _____________________________^ 76 | | Self { 77 | | loc: self.loc, 78 | | _node: PhantomData, 79 | | } 80 | | } | |_____^ help: change this to: `{ *self }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_clone_impl_on_copy_type = note: `#[deny(clippy::incorrect_clone_impl_on_copy_type)]` on by default
redundant pattern matching, consider using `is_some()`: compiler/toc-parser/src/grammar.rs#L443
warning: redundant pattern matching, consider using `is_some()` --> compiler/toc-parser/src/grammar.rs:443:20 | 443 | if let Some(..) = self::param_decl(p) { | -------^^^^^^^^---------------------- help: try this: `if self::param_decl(p).is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
redundant pattern matching, consider using `is_some()`: compiler/toc-parser/src/grammar/expr.rs#L482
warning: redundant pattern matching, consider using `is_some()` --> compiler/toc-parser/src/grammar/expr.rs:482:16 | 482 | if let Some(..) = expr::expect_comptime_expr(p) { | -------^^^^^^^^-------------------------------- help: try this: `if expr::expect_comptime_expr(p).is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
redundant pattern matching, consider using `is_some()`: compiler/toc-parser/src/grammar/expr.rs#L133
warning: redundant pattern matching, consider using `is_some()` --> compiler/toc-parser/src/grammar/expr.rs:133:16 | 133 | if let Some(..) = expr::expect_comptime_expr(p) { | -------^^^^^^^^-------------------------------- help: try this: `if expr::expect_comptime_expr(p).is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
redundant pattern matching, consider using `is_some()`: compiler/toc-parser/src/grammar/expr.rs#L104
warning: redundant pattern matching, consider using `is_some()` --> compiler/toc-parser/src/grammar/expr.rs:104:16 | 104 | if let Some(..) = expr::expect_expr(p) { | -------^^^^^^^^----------------------- help: try this: `if expr::expect_expr(p).is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
variable declared with type underscore: compiler/toc-validate/src/stmt.rs#L264
warning: variable declared with type underscore --> compiler/toc-validate/src/stmt.rs:264:5 | 264 | let find_cap_pair: _ = |a, b| used_caps.iter().find(|cap| cap.0 == a || cap.0 == b); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: remove the explicit type `_` declaration --> compiler/toc-validate/src/stmt.rs:264:22 | 264 | let find_cap_pair: _ = |a, b| used_caps.iter().find(|cap| cap.0 == a || cap.0 == b); | ^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_with_type_underscore = note: `#[warn(clippy::let_with_type_underscore)]` on by default
unnecessary `pub(self)`: compiler/toc-parser/src/grammar.rs#L455
warning: unnecessary `pub(self)` --> compiler/toc-parser/src/grammar.rs:455:1 | 455 | pub(self) fn param_decl(p: &mut Parser) -> Option<CompletedMarker> { | ^^^^^^^^^ help: remove it | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
unnecessary `pub(self)`: compiler/toc-parser/src/grammar.rs#L436
warning: unnecessary `pub(self)` --> compiler/toc-parser/src/grammar.rs:436:1 | 436 | pub(self) fn param_spec(p: &mut Parser) -> Option<CompletedMarker> { | ^^^^^^^^^ help: remove it | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
unnecessary `pub(self)`: compiler/toc-parser/src/grammar.rs#L423
warning: unnecessary `pub(self)` --> compiler/toc-parser/src/grammar.rs:423:1 | 423 | pub(self) fn param(p: &mut Parser) -> Option<(CompletedMarker, bool)> { | ^^^^^^^^^ help: remove it | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
unnecessary `pub(self)`: compiler/toc-parser/src/grammar.rs#L397
warning: unnecessary `pub(self)` --> compiler/toc-parser/src/grammar.rs:397:1 | 397 | pub(self) fn param_list(p: &mut Parser) -> Option<CompletedMarker> { | ^^^^^^^^^ help: remove it | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
unnecessary `pub(self)`: compiler/toc-parser/src/grammar.rs#L384
warning: unnecessary `pub(self)` --> compiler/toc-parser/src/grammar.rs:384:1 | 384 | pub(self) fn name_ref(p: &mut Parser) -> Option<CompletedMarker> { | ^^^^^^^^^ help: remove it | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
unnecessary `pub(self)`: compiler/toc-parser/src/grammar.rs#L343
warning: unnecessary `pub(self)` --> compiler/toc-parser/src/grammar.rs:343:1 | 343 | pub(self) fn name_list_of( | ^^^^^^^^^ help: remove it | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
unnecessary `pub(self)`: compiler/toc-parser/src/grammar.rs#L329
warning: unnecessary `pub(self)` --> compiler/toc-parser/src/grammar.rs:329:1 | 329 | pub(self) fn name(p: &mut Parser) -> Option<CompletedMarker> { | ^^^^^^^^^ help: remove it | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self = note: `#[warn(clippy::needless_pub_self)]` on by default
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: compiler/toc-reporting/src/message.rs#L32
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> compiler/toc-reporting/src/message.rs:32:30 | 32 | self.messages.extend(other.messages.into_iter()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `other.messages` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/collect.rs:377:18 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
this is an outer doc comment and does not apply to the parent module or crate: compiler/toc-paths/src/paths.rs#L1
warning: this is an outer doc comment and does not apply to the parent module or crate --> compiler/toc-paths/src/paths.rs:1:1 | 1 | ///! Core path entities | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments = note: `#[warn(clippy::suspicious_doc_comments)]` on by default help: use an inner doc comment to document the parent module or crate | 1 | //! Core path entities |
build (ubuntu-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build (ubuntu-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build (ubuntu-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build (ubuntu-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build (windows-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (windows-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build (windows-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build (windows-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build (windows-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/