-
Notifications
You must be signed in to change notification settings - Fork 32
norm detrend fix #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
norm detrend fix #78
Conversation
…nded and zscoring
anniegbryant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, Josh! The green-colored print messages explicitly stating whether detrending and/or normalizing were applied are a nice touch, and the docstring for the Data class summarizes the detrending + normalization steps well.
Thanks Annie! |
This PR fixes a bug in which time-series datasets were incorrectly normalised before de-trending. The following changes have been made:
detrendandnormaliseflags when instantiating theCalculator()object. Both pre-processing steps are enabled by default (as per previous versions of pyspi).coloramadependency.While the reversal of pre-processing operations will not introduce breaking changes for existing users, a discrepancy between results obtained for pyspi < 2.0.0 and pyspi >= 2.0.0 is expected.