i#7230 simrefs: Change skip_refs to not count markers #7570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the -skip_refs drmemtrace option to not count markers, matching the -sim_refs and -warmup_refs options. (The new -skip_records counts markers.) Adds a changelist entry. Updates the docs for -skip_refs, -sim_refs, and -warmup_refs to clarify that they do not count markers. Augments the drcachesim unit tests to check markers. Cleanups up the cache and tlb simulators to not short-circuit on a marker and skip later marker code, which requires a different solution for core_for_thread handling of early markers and setting the tid in tests. A separate change will remove -skip_refs and -sim_refs from the view tool. Issue: #7230
ivankyluk
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the -skip_refs drmemtrace option to not count markers, matching the -sim_refs and -warmup_refs options. (The new -skip_records counts markers.)
Adds a changelist entry.
Updates the docs for -skip_refs, -sim_refs, and -warmup_refs to clarify that they do not count markers.
Augments the drcachesim unit tests to check markers.
Cleans up the cache and tlb simulators to not short-circuit on a marker and skip later marker code, which requires a different solution for core_for_thread handling of early markers and setting the tid in tests.
A separate change will remove -skip_refs and -sim_refs from the view tool.
Issue: #7230