feat(clients): allow custom http headers #1906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0weinberger
changed the title
d0weinberger
force-pushed
the
feat/allow-custom-http-headers
branch
from
7f0de93 to
6f18853
Compare
d0weinberger
force-pushed
the
feat/allow-custom-http-headers
branch
3 times, most recently
from
c8217bb to
874a4a3
Compare
arthurpitman
reviewed
Jun 4, 2025
d0weinberger
force-pushed
the
feat/allow-custom-http-headers
branch
3 times, most recently
from
64514cf to
712fd67
Compare
Kirdock
reviewed
Jun 5, 2025
d0weinberger
force-pushed
the
feat/allow-custom-http-headers
branch
2 times, most recently
from
b8cd2cb to
7c00e10
Compare
Kirdock
previously approved these changes
Jun 5, 2025
arthurpitman
reviewed
Jun 6, 2025
arthurpitman
reviewed
Jun 6, 2025
arthurpitman
reviewed
Jun 6, 2025
arthurpitman
previously approved these changes
Jun 6, 2025
The environment variable `MONACO_ADDITIONAL_HTTP_HEADERS` is defined and the logic for parsing a http header map from the env var content is defined and tested.
This commit adds a dependency to the specific core lib commit which contains the feature of settings additional custom http headers. # Conflicts: # go.mod # go.sum
The additional http headers set via `MONACO_ADDITIONAL_HTTP_HEADERS` are parsed and used in all places where a client factory is used to create REST clients. Additionally, it is parsed once in the runner in order to log the keys of the additional HTTP headers right at the start of Monaco.
d0weinberger
force-pushed
the
feat/allow-custom-http-headers
branch
from
7c00e10 to
29b8637
Compare
|
Kirdock
approved these changes
Jun 6, 2025
arthurpitman
approved these changes
Jun 6, 2025
arthurpitman
added
the
run-e2e-test
E2E Test Results 3 files - 1 152 suites - 128 25m 31s ⏱️ - 27m 1s Results for commit 29b8637. ± Comparison against base commit d6638c7. This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Allowing users to set additional HTTP headers for requests.
What has changed?
The multiline environment variable
MONACO_ADDITIONAL_HTTP_HEADERSis introduced. Its content is parsed. Each line represents an HTTP header. The key- and value part of the header are separated via:. These HTTP headers are appended to all requests sent via Monaco.How does it do it?
The variable is retrieved and parsed at all places where the client factory is used to create REST clients. It is also parsed once at the start of Monaco to log the header keys, if any are present.
How is it tested?
To be done.
Currently, only parsing the environment variable contents is tested. Passing it to the clients is not tested yet.
How does it affect users?
Allowing users to set additional HTTP headers for requests via the environment variable
MONACO_ADDITIONAL_HTTP_HEADERS.