Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify URL parsing for CSI driver endpoint argument #4009

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gkrenn
Copy link
Contributor

@gkrenn gkrenn commented Nov 4, 2024

Description

The CSI driver currently relies on a custom implementation for URI parsing. This pull request updates the logic to use the built-in net/url package and modifies the endpoint defined in the CSI daemonset to be an absolute path.

Jira

How can this be tested?

  • deploy the operator
  • the CSI driver running is proof enough, as the livenessprobe relies on the socket to be created.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (9d2972d) to head (95e01dd).

Files with missing lines Patch % Lines
pkg/controllers/csi/driver/server.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4009      +/-   ##
==========================================
- Coverage   64.58%   64.57%   -0.02%     
==========================================
  Files         397      397              
  Lines       26416    26411       -5     
==========================================
- Hits        17062    17055       -7     
- Misses       8028     8030       +2     
  Partials     1326     1326              
Flag Coverage Δ
unittests 64.57% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@albertogdd albertogdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants