Full Wave Momentum Coupling #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stem:leaf allocation variable can go negative without this limiter, which can cause negative stem carbon pools.
share/util/shr_flux_mod.F90
Outdated
There was a problem hiding this comment.
Line 139: Add comment about cor30a-wav
erinethomas
force-pushed
the
WaveMomentumCoupling
branch
from
bc5368e
to
e0f6b26
Compare
vanroekel
reviewed
Jul 26, 2024
| lines.append('<stream name="timeSeriesStatsDailyWaveOutput"') | ||
| lines.append(' type="output"') | ||
| lines.append(' precision="single"') | ||
| lines.append(' io_type="pnetcdf"') |
There was a problem hiding this comment.
from a discussion with @sbrus89 suggest changing the io_type toio_type="{}"'.format(ocn_pio_typename)
erinethomas
force-pushed
the
WaveMomentumCoupling
branch
from
2a838fd
to
9b7fe62
Compare
The stem:leaf allocation variable can go negative without this limiter, which can cause negative stem carbon pools. Fixes E3SM-Project#6591 [non-BFB]
erinethomas
force-pushed
the
WaveMomentumCoupling
branch
from
eeb05c0
to
2f732f2
Compare
i.e. wav_ocn_coup = 'none', 'one', or 'two' for no coupling,
one way coupling (ocn to wav), or full two way coupling
…nvil Pe layout for B case with waves
…s analysis member calculations)
erinethomas
force-pushed
the
WaveMomentumCoupling
branch
from
2f732f2
to
52e755d
Compare
erinethomas
force-pushed
the
WaveMomentumCoupling
branch
from
d6eb466
to
1d22ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW WAVE MOMENTUM COUPLING FEATURE
Full momentum coupling between WW3, MPAS-Ocean, and EAM is being implemented.
This discussion is for the purpose of getting a preliminary code review and feedback before an official PR is opened into E3SM.
This PR uses COARE3.0 flux calculation which is needed for wave coupling to atmosphere via charnock parameter.
A table summarizing all testing being performed is at the bottom of the page here:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4271702034/2024.Q2+WAVEWATCH+III+maintenance+developments
Suggestions welcome for additional testing that is needed to open a PR into E3SM.
a 100 year Fully coupled Simulation is currently being done.
The use of WW3 is 'stealth' in that WW3 is NOT a standard component of E3SM for production runs. However, the implementation of wave-ocean-atm coupling in this PR defines the default coupling based upon the COMPSET used.
For example, a fully coupled base with active waves (B compset + WW3) will assume full, two-way coupling between WW3-EAM-MPASO and MPAS-SI. (note: limited wave-ice coupling for now, full wave-ice coupling coming in near future). On the other hand, if a data atmosphere used, like in a G Case+WW3, EAM-WW3 coupling will default to "one-way" (data winds passed to WW3) while full two way coupling is used between the active components of WW3 and MPAS-O/MPAS-SI.