-
Notifications
You must be signed in to change notification settings - Fork 456
Remove no-longer-needed support for 20km Greenland ice sheet mesh #7898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove no-longer-needed support for 20km Greenland ice sheet mesh #7898
Conversation
|
Note that there is some remaining language regarding the GIS 20km mesh here, in the context of lnd masks: And similarly at line 642. It may be that we should revisit these masks / regenerate them based on our newer meshes. If nothing else, the existing masks (if still used in the future) should be moved out of the "mpas.gis20km" subdir into one that is relevant to current / supported model configurations. This should be discussed / resolved as part of this PR. |
|
I also just noticed that the 'extra snowlayers test' is still using the 20 km grid. So we would want to update that test to use the 4-to-40km mesh before removing it (or we need to keep the 20 km grid around just for that, which seems silly). I will talk w/ Charlie Z. about that. |
|
As part of PR 7892, I've update the 'extra snowlayers' test so that it now uses the most recent v3, low-res. configuration (including the GIS 4-to-40km grid). So that conflict should be removed by the time the 'draft' qualifier is removed from this PR. |
|
@stephenprice -- we did merge PR 7892 so please rebase this whenever you get a chance? |
This commit removes basic support for model configurations that use the 20km, uniform resolution Greenland mesh, which is being replaced with the var. res. 4to40km Greenland mesh. This commit does NOT remove/replace support that has already been replaced as part of PR 7892, which updates testing support (and associated PE layouts) to use the 4to40km init. cond. file instead of the 20km file. The assumption is that these commits will be integrated sequentially. Conflicts resolved and rebased to master from 1/20/2026.
…and mesh. Fixed merge conflicts and rebased to master from 1/20/2026.
678bee5 to
18773fc
Compare
This PR removes remaining support for IG- and BG- configurations using the 20km, uniform Greenland ice sheet mesh. Because of some overlap with changes made in PR 7892, this PR is marked as draft-only for now. Once 7892 is merged, this branch will be synched with master as updated to a formal PR.