tweaks for homme_tool to handle large RRM grids (PR #7995) #7995
+251
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mt5555
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the HOMME tool scripts to improve handling of large RRM (regionally refined mesh) grids. The changes focus on script configuration and fixes to support grids with millions of elements that require special memory and parallelization settings.
Changes:
- Fixed
grid_dimsvalue in SCRIP file generation to correctly represent unstructured grids (value of 1 instead of grid size) - Removed unused
grid_cornersvariable from Python SCRIP output - Updated template job script with RRM grid support including higher
-cvalues for srun and configuration examples for large meshes
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| components/homme/test/tool/template.job | Added RRM grid configuration examples, updated srun parameters for large grids, and added mesh prefix support for flexible output naming |
| components/homme/test/tool/python/HOMME2SCRIP.py | Fixed grid_dims to use value 1 for unstructured grids and removed unused grid_corners coordinate variable |
| components/homme/test/tool/python/HOMME2META.py | New Python script to convert HOMME grid template files to latlon format (alternative to NCL version) |
| components/homme/test/tool/ncl/HOMME2SCRIP.ncl | Updated input filename and changed grid_imask to integer type, removed conditional NetCDF4 format setting |
| components/homme/test/tool/ncl/HOMME2META.ncl | Updated input filename and removed conditional NetCDF4 format setting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
components/homme/test/tool/python/HOMME2SCRIP.py:32
- Corrected grammar from 'which included' to 'which is included'.
This requires libraries such as xarray, which included in the E3SM unified environment:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
whannah1
approved these changes
Jan 16, 2026
HOMME2SCRIP.py: fix two bugs in variable metadata template.job: update namelist to demonstrate how to change output filename [BFB] Update components/homme/test/tool/template.job Co-authored-by: Copilot <[email protected]> Update components/homme/test/tool/python/HOMME2META.py Co-authored-by: Copilot <[email protected]> Update components/homme/test/tool/template.job Co-authored-by: Copilot <[email protected]> Update components/homme/test/tool/python/HOMME2META.py Co-authored-by: Copilot <[email protected]> Update components/homme/test/tool/python/HOMME2META.py Co-authored-by: Copilot <[email protected]> Update components/homme/test/tool/python/HOMME2SCRIP.py Co-authored-by: Copilot <[email protected]> Update components/homme/test/tool/python/HOMME2META.py Co-authored-by: Copilot <[email protected]> Update components/homme/test/tool/python/HOMME2META.py Co-authored-by: Copilot <[email protected]> typo in comments
Co-authored-by: Copilot <[email protected]>
Closed
mt5555
force-pushed
the
homme_tool_tweaks
branch
from
b74c321 to
e9cb07d
Compare
whannah1
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMME2SCRIP.py:
remove unused variable
fix grid_rank (1=unstructured grid, 2=lat/lon grid)
includes speedups from PR #7998
HOMME2META.py
added python version of script to create "latlon" file
template.job:
update namelist to demonstrate how to change output filename
add -c srun options needed for large RRM grids
[BFB] no source code changes - only changes to scripts used to generate atmospheric grid template files