EAMxx: fix run_t0 num steps before initializing output mgrs #8006
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of run_t0's num steps may be used to compute the timestamp of the next output during the OM init, so its value must already be correct
bartgol
added
bug fix PR
BFB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of run_t0's num steps may be used to compute the timestamp of the next output during the OM init, so its value must be correct before OM's are created.
[BFB]
Fixes #7682 .
@whannah1 if you still have that case somewhere and want to give this branch a try, that'd be great. If not, that's fine. I already checked on my workstation that the bug (which I could reproduce with a simple ne4pg2 F2010-SCREAMv1 case with no output streams) is gone with this branch, so I'm quite confident we caught it.
The issue was in the order in which we handled the creation of the output manager(s) and the restart of the num_steps counter inside out timestamps. The OM's were not getting the memo, b/c the restart file was read after the OM were created.