Add Pressure Gradient design document #226
Conversation
sbrus89
requested review from
mark-petersen,
xylar,
katsmith133,
mwarusz,
philipwjones,
vanroekel and
alicebarthel
|
Test compiled and posted here. |
| $$ | ||
|
|
||
| $\widetilde{H}$ is the prognositc variable in the barotropic continuity equation. | ||
| The vertical integral of the pressure gradient is |
There was a problem hiding this comment.
This is the vertical average, not the vertical integral, right?
| The vertical integral of the pressure gradient is | |
| The vertical average of the pressure gradient is |
| Therefore, the barotorpic pressure gradient term is discretized as: | ||
|
|
||
| $$ | ||
| \overline{T}_e^p = g\left[ \frac{H_i}{\widetilde{H}_i} \right]_e\sum_{i \in CE(e)} n_{e,i}\widetilde{H}_e |
There was a problem hiding this comment.
How will we know
| $$ | ||
| p(z) = p_b - g \int^z_{-h} \rho dz^\prime, | ||
| $$ |
There was a problem hiding this comment.
Why is
| private: | ||
| std::unique_ptr<PressureGrad> OmegaPressureGrad; | ||
| PressureGradCentered CenteredPGrad; | ||
| PressureGradHighOrder HighOrderPGrad; // To be implemented later |
There was a problem hiding this comment.
I'm not confident that we will have one and only one higher-order pressure gradient. We have several in MPAS-Ocean. Assuming that this is just a placeholder for one or more future classes, can we state that explicitly in the text?
| ## Verification and Testing | ||
|
|
||
| ### Test: Spatial convergence to exact solution | ||
| For a given analytical $v$, $h$, and $b$, the spatial convergence of the pressure gradient can be assessed by computing errors on progressively finer meshes. |
There was a problem hiding this comment.
I think maybe this should be fleshed out a bit more. What analytic test would we use?
| ### 2.1 Requirement: Support for tilted pressure coordinates for the non-Boussinesq primitive equations | ||
|
|
||
| The pressure gradient will compute the horizontal gradients of both the pressure and geopotential to support tilted pressure coordinates in the non-Boussinesq model. | ||
| This will allow for the use of a $p^\star$ coordinate, which functions similarly to the $z^\star$ in the Boussinesq MPAS-Ocean model. |
There was a problem hiding this comment.
will this be updated to the \tilde{z} coordinate instead of
There was a problem hiding this comment.
I was hoping we could continue calling it p* since \tilde{z}^* seems confusing.
This PR adds the design document for the pressure gradient module for Omega-1. Compiled version here.
Checklist