-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove manufactured_soluiton
test case from suites
#92
Remove manufactured_soluiton
test case from suites
#92
Conversation
I think we want to remove this test from our suites for now since it is failing "on purpose" (i.e. we know the MPAS-Ocean code needs to be fixed to allows the solution to converge at the desired rate) but this is confusing for those who are trying to use these suites to validate unrelated code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I'm finishing up verifying the fix in E3SM-Ocean-Discussion/E3SM#55 for time varying forcing and then that should be set to move over to a E3SM-Project PR. Hopefully we can get this resolved in the next week or two.
@cbegeman, just wanted to make sure this is okay with you, too. I haven't tested this yet but will as soon as I can. |
@altheaden, if you want, you can test if this fixes the problem you were having, but I'll test it as well. |
@xylar I did some testing last night in a branch with the exact change you've made here, and it worked perfectly. |
TestingI tested this with the |
@cbegeman, I know you're away having fun so don't worry about this one. We can turn this testing back on once you're back. |
Thanks @sbrus89 and @altheaden! |
@xylar and @altheaden Thanks for taking care of this while I was away. I don't have any problem with waiting to add this back to the suites until after we get convergence with MPAS-O. |
I think we want to remove this test from our suites for now since it is failing "on purpose" (i.e. we know the MPAS-Ocean code needs to be fixed to allows the solution to converge at the desired rate) but this is confusing for those who are trying to use these suites to validate unrelated code.
Checklist
Testing
comment in the PR documents testing used to verify the changescloses #89