External links open in new tabs #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malloryfreeberg
changed the title
8 tasks
M-casado
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
LGTM. Checked a few links of each page and they work fine (in Mallory's forked GitHub pages).
I have not checked the full set of documents, though, searching for external links that escaped this PR.
| | Data Use Ontology (DUO) | Allows users to semantically tag datasets with usage restrictions so datasets can be automatically discoverable based on a researcher's authorization level or intended use. | 2021-02-23 | 2021-02-23 | <a href="https://github.com/EBISPOT/DUO" target="_blank">Specification</a>, <a href="https://ega-archive.org/data-use-conditions" target="_blank">Documentation</a>, <a href="https://www.ebi.ac.uk/ols/api/ontologies" target="_blank">Endpoint</a> | <a href="https://doi.org/10.1016/j.xgen.2021.100028" target="_blank">DOI</a> | | ||
| | htsget | Enables secure, efficient, and reliable access to sequencing read and variation data including specific genomic regions. | v1.3.0 | v1.0.0 | <a href="http://samtools.github.io/hts-specs/htsget.html" target="_blank">Specification</a>, <a href="https://github.com/EGA-archive/ega-download-client" target="_blank">Documentation</a>, <a href="https://ega.ebi.ac.uk:8052/elixir/tickets/tickets" target="_blank">Endpoint</a> | <a href="https://doi.org/10.1093/bioinformatics/bty492" target="_blank">DOI</a> | | ||
| | refget | Enables access to reference sequences using an identifier derived from the sequence itself. | v1.2.6 | N/A | <a href="http://samtools.github.io/hts-specs/refget.html" target="_blank">Specification</a>, Documentation, Endpoint | <a href="https://doi.org/10.1093/bioinformatics/btab524" target="_blank">DOI</a> | | ||
| | Researcher IDs (Passports, Visas) | Specifies the collection of researchers that may access a dataset at any given time, and the credentials they must supply. | v1.0.1 | v1.0.1 | <a href="https://github.com/ga4gh-duri/ga4gh-duri.github.io/blob/master/researcher_ids/ga4gh_passport_v1.md" target="_blank">Specification</a>, <a href="https://docs.google.com/document/d/1FTzUYAfV5d2a0zoDkbY9Iy_L5NbSAnHeWnmY2NIrY8M/edit" target="_blank">Documentation</a>, <a href="https://ega.ebi.ac.uk:8443/ega-permissions/swagger-ui/index.html" target="_blank">Endpoint</a> | <a href="https://doi.org/10.1016/j.xgen.2021.100030" target="_blank">DOI</a> | |
There was a problem hiding this comment.
Out of curiosity, why have Visas in uppercase? I've seen the DOI where they put the "passport" specification with uppercase, but not visas. And wouldn't it be "Passports and visas"?
There was a problem hiding this comment.
I just wanted to highlight line 49, but git highlighted all these. Sorry about that 😃
There was a problem hiding this comment.
Changed to "visas"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Currently, links to external materials/sites are opened in the same tab that is currently being used. If someone wants to go back to the FEGA pages, they have to navigate back from where they are. A better user experience would be that external links open in a new tab in the same window, so that a user can easily switch back to the FEGA pages without losing access to the external materials they just opened. Internal links to other pages in the FEGA website can stay in the same tab, since it doesn't navigate someone away from the FEGA website. This PR addressed Issue #26.
How has this been tested?
Changes have been tested in my fork by enabling GitHub pages to build a local copy of the website. All website links were then checked (using Mac & Google Chrome) that:
NB Links won't open correctly in GitHub markdown; GitHub pages must be built to test.
What should reviewers focus on?
Types of changes
Checklist: