Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added suggestion for what to review to PR template #33

Conversation

malloryfreeberg
Copy link
Contributor

Description

  • Added section to PR template to request PR author provide suggestions for what reviewer should test/check/review.

Motivation and Context

By providing this information, the author can help reviewers know what they should be testing/checking/reviewing in the PR. It should not be an exhaustive list, but provide some hints for the reviewer.

How has this been tested?

Tested manually in PR #32.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING.md guide.
  • My changes follow the code style of this project.
  • I have updated supporting documentation, if required.
  • I have added my details to the CONTRIBUTORS.yaml file.

@malloryfreeberg malloryfreeberg added the documentation Improvements or additions to documentation label Aug 15, 2022
Copy link
Collaborator

@M-casado M-casado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition 👍

@malloryfreeberg malloryfreeberg merged commit b240356 into EGA-archive:main Aug 15, 2022
@malloryfreeberg malloryfreeberg deleted the feature/add-review-suggestions-pr-template branch August 15, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants