Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-31 - Added link to CA #39

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Issue-31 - Added link to CA #39

merged 2 commits into from
Oct 11, 2022

Conversation

M-casado
Copy link
Collaborator

Both Silvia and I added some context to the Collaboration Agreement (CA) to the legal-governance section of the ReadTheDocs.

Description

Motivation and Context

  • New link of the CA was available.

How has this been tested?

What should reviewers focus on?

  • The Link works and redirects to the current CA version
  • Context of the version is self explanatory and easy to understand.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING.md guide.
  • My changes follow the code style of this project.
  • I have updated supporting documentation, if required.
  • I have added my details to the CONTRIBUTORS.yaml file.

@M-casado M-casado added the documentation Improvements or additions to documentation label Oct 10, 2022
@M-casado M-casado self-assigned this Oct 10, 2022
silviabah
silviabah approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@silviabah silviabah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modification is the same as: https://m-casado.github.io/FEGA-onboarding/topics/governance-legal/#2-implement-legal-frameworks

Where the link works correctly and the context was added :)

@malloryfreeberg malloryfreeberg linked an issue Oct 10, 2022 that may be closed by this pull request
Add link to FEGA Collaboration Agreement #31
Closed
malloryfreeberg
malloryfreeberg suggested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@malloryfreeberg malloryfreeberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked @M-casado 's fork and the link and context look good to me 👍
  • One request: Since @silviabah helped with this change/PR, can the contributor list please be updated with her details as part of this PR?

@M-casado
Copy link
Collaborator Author

Done, @malloryfreeberg 👍

malloryfreeberg
malloryfreeberg approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@malloryfreeberg malloryfreeberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@M-casado M-casado merged commit 9662a09 into EGA-archive:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silviabah silviabah silviabah approved these changes

@malloryfreeberg malloryfreeberg malloryfreeberg approved these changes

Assignees

@M-casado M-casado

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add link to FEGA Collaboration Agreement
3 participants
@M-casado @malloryfreeberg @silviabah