New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #42 bug "Search 404 error" #50

Merged

M-casado merged 7 commits into EGA-archive:main from ahornos:main

May 15, 2023

Collaborator

ahornos commented May 15, 2023

Description

Adds baseurl variable at configuration (usually used at jeckyll themes at github pages)
Change some filters at search.html variables in order to take absolute paths
Bonus: sort contributors list

Motivation and Context

Fix search box bug (404 error)
[BUG]: Search function not working #42

How has this been tested?

Search any word with search box and go to any result

What should reviewers focus on?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New content (non-breaking change which adds new content)
Modified content (non-breaking change which modifies existing content)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

I have read the CONTRIBUTING.md guide.
My changes follow the code style of this project.
I have updated supporting documentation, if required.
I have added my details to the CONTRIBUTORS.yaml file.

ahornos and others added 7 commits

May 15, 2023 13:48


          fix: EGA-archive#42 fix search_data 404

099fcab


          fix: EGA-archive#42 fix search_data item absolute url

f46027b


          fix: EGA-archive#42 fix search_data items url

ee46494


          fix: EGA-archive#42 fix search box adding baseurl to config

064be4e


          fix: EGA-archive#42 configure baseurl as jeckyll style

3069fc8


          Merge branch 'EGA-archive:main' into main

323c640


          content: sort Contributors

cc5038a

M-casado added the FEGA-thon label

M-casado self-requested a review

May 15, 2023 14:27

M-casado assigned ahornos

M-casado approved these changes

View reviewed changes

Collaborator

M-casado left a comment

Reviewed changes and checked at @ahornos fork. Example:

https://ahornos.github.io/FEGA-onboarding/search.html?q=maturity

M-casado merged commit 661e026 into EGA-archive:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels