Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated broken URLs. Fixes #72. #79

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

malloryfreeberg
Copy link
Contributor

@malloryfreeberg malloryfreeberg commented Feb 15, 2024

Description

  • Fixed majority of broken URLs (mostly caused by EGA and GA4GH relaunching their websites) listed in Issue [BUG]: Broken links #72.
  • Did not fix a broken Beacon-related URL. All the Beacon info needs to be updated and should be done in a separate PR.
  • Did not fix the https://ega.ebi.ac.uk:8052/elixir/tickets/tickets link as this is meant to be a call to our data distribution API endpoints directly, which current we don't have documentation for.

Motivation and Context

It's important to have working URLs!

How has this been tested?

Updated URLs were tested in Google Chrome.

What should reviewers focus on?

Do the URLs also work for the reviewer.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING.md guide.
  • My changes follow the code style of this project.
  • I have updated supporting documentation, if required.
  • I have added my details to the CONTRIBUTORS.yaml file.

@malloryfreeberg malloryfreeberg added the bug Something isn't working label Feb 15, 2024
@malloryfreeberg malloryfreeberg marked this pull request as ready for review February 22, 2024 15:16
Copy link
Collaborator

@M-casado M-casado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links LGTM 👍

@malloryfreeberg malloryfreeberg merged commit a86ed3a into main Feb 23, 2024
@malloryfreeberg malloryfreeberg deleted the mf-update-broken-urls-#72 branch February 23, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants