Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onboarding journey figure to v2.0 #80

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

malloryfreeberg
Copy link
Contributor

Description

  • Added v2.0 of onboarding figure to GH
  • Linked v2.0 figure to website homepage
  • Updated text about figure to reference new dependency

Motivation and Context

FEGA Operations Committee agreed that test CEGA credentials should only be issued to nodes that have demonstrated enough progress

How has this been tested?

Repo was cloned locally and the website built locally and launched to see new change.

What should reviewers focus on?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING.md guide.
  • My changes follow the code style of this project.
  • I have updated supporting documentation, if required.
  • I have added my details to the CONTRIBUTORS.yaml file.

@malloryfreeberg malloryfreeberg added the documentation Improvements or additions to documentation label Feb 16, 2024
Copy link
Collaborator

@amycurwin amycurwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's minor, but the stars look off-centred. I see it is not just on the website version but also in the image here. Did something go weird uploading it here, maybe? The version Ana showed me had the stars nicely in the centre of the circle. I could ask her for a version without circles. It could be the easier solution.


<img src="./assets/img/Path-to-becoming-FEGA-member-v1.0.svg" alt="Colored diagram with icons and descriptions of technical and governance steps an interested Federated EGA Node needs to complete to join the Federated EGA." width="1200" align="right" />
<img src="./assets/img/Path-to-becoming-FEGA-member-v2.0.svg" alt="Colored diagram with icons and descriptions of technical and governance steps an interested Federated EGA Node needs to complete to join the Federated EGA." width="1200" align="right" />

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe an extra space after the image, before the next text would look better
imagen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amycurwin added a space - can you pull my changes and load the website again to check how it looks?

@malloryfreeberg
Copy link
Contributor Author

It's minor, but the stars look off-centred. I see it is not just on the website version but also in the image here. Did something go weird uploading it here, maybe? The version Ana showed me had the stars nicely in the centre of the circle. I could ask her for a version without circles. It could be the easier solution.

I think it's fine as-is.

Copy link
Collaborator

@amycurwin amycurwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now!

@malloryfreeberg malloryfreeberg merged commit 33bcfb4 into main Feb 22, 2024
@malloryfreeberg malloryfreeberg deleted the mf-update-onboarding-journey-figure branch February 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants