Skip to content

Use branch_name_extension and auto-merge dependency PRs#369

Merged
CasperWA merged 3 commits intomasterfrom
cwa/fix-365-ci-check-dependencies
Oct 26, 2023
Merged

Use branch_name_extension and auto-merge dependency PRs#369
CasperWA merged 3 commits intomasterfrom
cwa/fix-365-ci-check-dependencies

Conversation

@CasperWA
Copy link
Contributor

Description:

Fixes #365 by bumping to SINTEF/ci-cd v2.5.3 and also using the branch_name_extension input in the CI - Check dependencies workflow for the PR targeting the release/pydantic-v1-support branch.

Furthermore, we add the created PRs from the CI - Check dependencies workflow to be auto-merged (if all CI checks succeed), plus all @dependabot PRs (as well as the PR from the CI - Check dependencies branch) will be auto-merged into the release/pydantic-v1-support branch if they succeed the other CI checks.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

dependabot bot and others added 3 commits October 26, 2023 13:18
Bumps [SINTEF/ci-cd](https://github.com/sintef/ci-cd) from 2.5.2 to 2.5.3.
- [Release notes](https://github.com/sintef/ci-cd/releases)
- [Changelog](https://github.com/SINTEF/ci-cd/blob/main/CHANGELOG.md)
- [Commits](SINTEF/ci-cd@v2.5.2...v2.5.3)

---
updated-dependencies:
- dependency-name: SINTEF/ci-cd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Extend the created branch name only when targeting the
`release/pydantic-v1-support` branch.
Add `release/pydantic-v1-support` to target branches, to automatically
merge dependabot and CI - check dependencies PRs into this branch as
well.
@CasperWA CasperWA requested a review from Treesarj October 26, 2023 11:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf9ece9) 82.25% compared to head (659081e) 82.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   82.25%   82.25%           
=======================================
  Files          44       44           
  Lines        1257     1257           
=======================================
  Hits         1034     1034           
  Misses        223      223           
Flag Coverage Δ
linux 82.17% <ø> (ø)
linux-strategies 84.50% <ø> (ø)
windows 81.73% <ø> (ø)
windows-strategies 83.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CasperWA CasperWA merged commit 33021ef into master Oct 26, 2023
@CasperWA CasperWA deleted the cwa/fix-365-ci-check-dependencies branch October 26, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PRs for updating dependencies not opened

3 participants