Skip to content

Conversation

@silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented Nov 20, 2025

Implemented changes

This fixes the "guessing" of feature projection based on content. It was working for Polygons, but for other types (Point, MultiPolygon etc.) the accessing of the reference coordinate was either one level "too high" or "too low". This PR introduces a new helper function findFirstCoordinateValue that recursively gets the first number and uses that as reference coordinate.

This is used at the eox-map parseFeatures method, which is also used inside of eox-drawtools.

Screenshots/Videos

Before

image

After

image

Checklist before requesting a review

@netlify
Copy link

netlify bot commented Nov 20, 2025

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit ecd405b
🔍 Latest deploy log https://app.netlify.com/projects/eoxelements/deploys/691f089e48ad3100075023c3
😎 Deploy Preview https://deploy-preview-1959--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@silvester-pari silvester-pari marked this pull request as ready for review November 20, 2025 10:43
Copy link
Collaborator

@RobertOrthofer RobertOrthofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is correct, the epsg codes were switched 👍

@silvester-pari silvester-pari marked this pull request as draft November 20, 2025 11:30
@silvester-pari silvester-pari marked this pull request as ready for review November 20, 2025 12:31
@silvester-pari silvester-pari merged commit 9cfc412 into main Nov 20, 2025
10 checks passed
@silvester-pari silvester-pari deleted the map/fix/parse-projection branch November 20, 2025 12:32
@github-actions github-actions bot mentioned this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants