Skip to content

Added support for Smarthjemmet.dk QUAD-ZIG-SW 4 button remote #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Nicolai-
Copy link
Contributor

Added support for Smarthjemmet.dk QUAD-ZIG-SW 4 button remote (https://www.zigbee2mqtt.io/devices/QUAD-ZIG-SW.html)

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

Added Controller for Smarthjemmet.dk QUAD-ZIG-SW 4 button remote and implemented support in light hook
The documentation part is untested.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Copy link
Contributor

Hey @Nicolai-, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@EPMatt EPMatt force-pushed the ns_smarthjemmet_dk_quad_zig_sw branch from 8a3381a to d0e967f Compare February 16, 2025 23:21
Copy link
Contributor

Hey @EPMatt, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@EPMatt EPMatt force-pushed the ns_smarthjemmet_dk_quad_zig_sw branch from d0e967f to 8abf256 Compare February 16, 2025 23:24
Copy link
Contributor

github-actions bot commented Feb 16, 2025

Hey @Nicolai-, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Copy link
Contributor

github-actions bot commented Feb 16, 2025

Hey @Nicolai- ,

❌ It looks like there are some issues with your contribution. Don't worry, here's some additional information and guidance on how to solve them.

  • Your submission includes some code style issues. We invite you to inspect the output of the Pull Request checks and fix reported errors and warnings.

Please fix reported issues, then submit your updates here. If you have any questions or doubts, you can always contact a project maintainer. :)

Thanks!

@yarafie
Copy link
Contributor

yarafie commented Feb 28, 2025

@Nicolai- Nicolai- force-pushed the ns_smarthjemmet_dk_quad_zig_sw branch from 9a3589d to d419b36 Compare March 3, 2025 15:51
@Nicolai-
Copy link
Contributor Author

Nicolai- commented Mar 3, 2025

@Nicolai-

https://yarafie.github.io/awesome-ha-blueprints/docs/blueprints/controllers/smarthjemmet_dk_quad_zig_sw

Thanks, I will try to look into it setting it up again, so I can see the docs on my own fork another time :)

@Nicolai-
Copy link
Contributor Author

Nicolai- commented Mar 3, 2025

I cleaned up a bit and started using @yarafie aproach about implicit choosing the integration based on trigger ids from #693

Also removed everything relating to "Last Controller Event" as this is not needed for this controller as the double/tripple press is not a virtual event for this controller

@yarafie
Copy link
Contributor

yarafie commented Mar 3, 2025

I cleaned up a bit and started using @yarafie aproach about implicit choosing the integration based on trigger ids from #693

Also removed everything relating to "Last Controller Event" as this is not needed for this controller as the double/tripple press is not a virtual event for this controller

Updated my fork with your latest version.

@Nicolai- Nicolai- force-pushed the ns_smarthjemmet_dk_quad_zig_sw branch from 578cb12 to fe78846 Compare March 3, 2025 19:50
Copy link
Contributor

Hey @EPMatt, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Copy link
Contributor

github-actions bot commented Mar 30, 2025

Hey @Nicolai-,

✅ Your contribution passed all the checks, awesome!
A maintainer will soon review your submission and provide additional feedback regarding your changes.

Thanks again for dedicating your precious time to this project. 🔥

📝 Updated blueprints included in this PR can be tested by importing them in Home Assistant via the following links.

https://github.com/Nicolai-/awesome-ha-blueprints/blob/ns_smarthjemmet_dk_quad_zig_sw/blueprints/controllers/smarthjemmet_dk_quad_zig_sw/smarthjemmet_dk_quad_zig_sw.yaml
https://github.com/Nicolai-/awesome-ha-blueprints/blob/ns_smarthjemmet_dk_quad_zig_sw/blueprints/hooks/light/light.yaml

Copy link
Contributor

github-actions bot commented Mar 30, 2025

Hey @EPMatt,

❌ It looks like there are some issues with your contribution. Don't worry, here's some additional information and guidance on how to solve them.

Please fix reported issues, then submit your updates here. If you have any questions or doubts, you can always contact a project maintainer. :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants