Skip to content

updates to docs, alignment, miscellaneous #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sealevelponds2
Choose a base branch
from

Conversation

eclare108213
Copy link

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    updated docs, fixed/reverted alignment and other unwanted changes
  • Developer(s):
    @eclare108213
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ENTER INFORMATION HERE
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

ice_flux:

  • moved swuvrdf,f and swpardr,f initializations out of allocate routine and into initialization routine
  • specified which allocation command ran out of memory

ice_init:

  • fixed misalignments

ice_step_mod:

  • reverted alignment, TLAT, TLON, n changes to code in main

docs:

  • added apnd_sl, tscale_pnd_drain, tr_pond_sealvl
  • generalized troubleshooting comments for ponds and noted mass calculation inconsistencies
  • moved saltflux_option into S section

@eclare108213
Copy link
Author

@dabail10 @apcraig
I did this very quickly, without having set up cice for testing locally. I'm happy to fix problems tomorrow...
I found a few things that were out of place so went ahead and fixed them, even though they weren't pond related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant