Skip to content

ctsm5.3.045: Update FATES tag and default parameter file (API 40) #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 20, 2025
Merged

ctsm5.3.045: Update FATES tag and default parameter file (API 40) #3087

merged 8 commits into from
May 20, 2025

Conversation

@glemieux
Copy link
Collaborator

@glemieux glemieux commented Apr 23, 2025 •
edited by ekluzek
Loading

Description of changes

Updates the default FATES parameter file and tag

Specific notes

This parameter file update includes updates from the following FATES pull requests:

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? Yes for FATES

Any User Interface Changes (namelist or namelist defaults changes)? Yes new FATES parameter file

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: regular + fates

@glemieux glemieux moved this to In progress - master in CTSM: Upcoming tags Apr 23, 2025
@glemieux glemieux self-assigned this Apr 23, 2025
@glemieux
Copy link
Collaborator Author

glemieux commented May 6, 2025 •
edited
Loading

I've updated the original comment to remove the goal of including NGEET/fates#1392 parameter file updates as it's complex enough and depends on NGEET/fates#1355 that I think staging this in a subsequent API update would be less complicated.

This was referenced May 7, 2025
Merged
Closed
Merged
@glemieux glemieux changed the title Update FATES tag and default parameter file Update FATES tag and default parameter file (API 40) May 12, 2025
@glemieux
Copy link
Collaborator Author

Regression testing the fates suite for the associated default parameter changes as noted in the original comment are complete. This PR will be updated soon with the new default and eventually the fates tag associated with NGEET/fates#1406.

@ekluzek ekluzek added this to the ctsm5.4 FATES Freeze milestone May 12, 2025
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM non-bfb Changes answers (incl. adding tests) labels May 12, 2025
glemieux added 2 commits May 12, 2025 15:10
@glemieux
Merge tag 'ctsm5.3.043' into fates-default-param-tag-update
0c452c3 
Merge b4bdev 20250509

Updates to the b4b-dev branch since its last merge to master (PRs ESCOMP#3091 ESCOMP#3092), as shown by git log:

- Merge pull request Update docs infrastructure ESCOMP#2809 from samsrabin/update-docs-builder-2
  Update docs infrastructure
- Merge pull request Update externals to cesm3_0_alpha06c ESCOMP#3106 from ekluzek/update_to_alpha06c
  Update externals to cesm3_0_alpha06c
- Merge pull request User control over snow thermal conductivity scheme over glaciers ESCOMP#3072 from wwieder/JordanGlacier
  User control over snow thermal conductivity scheme over glaciers
@glemieux
update default fates parameter file for API 40
315e736
@glemieux
Copy link
Collaborator Author

glemieux commented May 12, 2025 •
edited
Loading

To do:

  • generate and move default parameter file to input data storage on derecho
  • rimport default parameter file
  • update fates tag

@samsrabin samsrabin changed the title Update FATES tag and default parameter file (API 40) ctsm5.3.046: Update FATES tag and default parameter file (API 40) May 15, 2025
@glemieux glemieux marked this pull request as ready for review May 15, 2025 17:15
@glemieux glemieux requested a review from rgknox May 15, 2025 17:15
@ekluzek ekluzek changed the title ctsm5.3.046: Update FATES tag and default parameter file (API 40) ctsm5.3.045: Update FATES tag and default parameter file (API 40) May 19, 2025
ekluzek
ekluzek approved these changes May 19, 2025
View reviewed changes
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead simple change on the CTSM side of things.

@ekluzek ekluzek self-assigned this May 19, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented May 19, 2025

@glemieux OK this is next in line now. I'll complete it once you are done with testing and the changelog for it.

@glemieux glemieux moved this from Hold to Final Testing in FATES Pull Request Planning and Status May 19, 2025
glemieux added 2 commits May 19, 2025 16:27
@glemieux
Merge tag 'ctsm5.3.044' into fates-default-param-tag-update
a016641 
Introduce time-evolving LEAFCN_TARGET as function of leafcn parameter

Read leafcn from the paramfile and calculate time-evolving leafcn_target
from it
@glemieux
update fates tag commit
d94d0a6
@glemieux
Copy link
Collaborator Author

Regression testing against ctsm5.3.044 is underway on izumi and derecho

@glemieux
Copy link
Collaborator Author

Regression testing on derecho is complete. All non-fates test are b4b. The fates test results are expected and consistent with testing per NGEET/fates#1406.

Results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr3087-aux_clm

Still waiting on test results from izumi.

@glemieux
Copy link
Collaborator Author

Testing on izumi is B4B.

This is ready to integrate.

results: /scratch/cluster/glemieux/ctsm-tests/tests_0520-010733iz

@ekluzek ekluzek merged commit bb7bc6c into ESCOMP:master May 20, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags May 20, 2025
@github-project-automation github-project-automation bot moved this from Final Testing to Ready to Integrate in FATES Pull Request Planning and Status May 20, 2025
@ekluzek ekluzek deleted the fates-default-param-tag-update branch May 20, 2025 19:37
@ekluzek ekluzek restored the fates-default-param-tag-update branch May 20, 2025 19:40
@ekluzek ekluzek deleted the fates-default-param-tag-update branch May 20, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekluzek ekluzek ekluzek approved these changes

@rgknox rgknox Awaiting requested review from rgknox

Assignees

@glemieux glemieux

@ekluzek ekluzek

Labels

enhancement new capability or improved behavior of existing capability FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM non-bfb Changes answers (incl. adding tests)

Projects

CTSM: Upcoming tags
Status: Done (non release/external)

Milestone

Pre-ctsm6 FATES SP Freeze

Development

Successfully merging this pull request may close these issues.

2 participants

@glemieux @ekluzek