-
Notifications
You must be signed in to change notification settings - Fork 135
Adding figures of Bock and Lauer (2024) #3526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you so much @schlunma for the review! I tried my best regarding the codacy issues. Could we leave it like that? |
Co-authored-by: Manuel Schlund <[email protected]>
Thanks @schlunma for reviewing! |
I still get the "invalid ancestor" error from |
Ah, and there is a I am not quite sure what the problem is, I guess it's either a recipe problem (this warning appears in all 3 recipes) or a syntax error in the bibtex file you added (esmvaltool/references/bock24acp.bibtex). |
Hi @schlunma , both issues should be solved now. In my tests, there are no warnings anymore. |
Co-authored-by: Manuel Schlund <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lisa, looks good now! All recipes ran successful and their output looks good 🚀
Description
In this PR we add the figures of Bock and Lauer, 2024
Fig. 3: Geographical maps of cloud properties
Fig. 4: Geographical maps of net cloud radiative effect
Fig. 6: Zonal averages of cloud properties and their relative projected changes
Fig. 7: Boxplots of relative changes in projected cloud properties
Note: In Figure 3 only the total cloud fraction is included and liquid and ice water path are commented out. The reason is a different standard name of these two variables in CMIP5 and CMIP6 which doesn't allow a computation of the multi model mean by the preprocessor. Iris is working on a solution of the problem: SciTools/iris#5313 (review)
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
🛠 Any changed dependencies have been added or removed correctlyNew or updated recipe/diagnostic