Skip to content

Adding figures of Bock and Lauer (2024) #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 162 commits into from
Jan 10, 2025
Merged

Adding figures of Bock and Lauer (2024) #3526

merged 162 commits into from
Jan 10, 2025

Conversation

LisaBock
Copy link
Contributor

@LisaBock LisaBock commented Feb 9, 2024

Description

In this PR we add the figures of Bock and Lauer, 2024

Fig. 3: Geographical maps of cloud properties
Fig. 4: Geographical maps of net cloud radiative effect
Fig. 6: Zonal averages of cloud properties and their relative projected changes
Fig. 7: Boxplots of relative changes in projected cloud properties

Note: In Figure 3 only the total cloud fraction is included and liquid and ice water path are commented out. The reason is a different standard name of these two variables in CMIP5 and CMIP6 which doesn't allow a computation of the multi model mean by the preprocessor. Iris is working on a solution of the problem: SciTools/iris#5313 (review)


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

@LisaBock
Copy link
Contributor Author

Thank you so much @schlunma for the review!

I tried my best regarding the codacy issues. Could we leave it like that?

@LisaBock
Copy link
Contributor Author

LisaBock commented Jan 7, 2025

Thanks @schlunma for reviewing!
I changed the line about the ancestor files in the other two diagnostic scripts as well. Hopefully, it's all fine now.

@schlunma
Copy link
Contributor

schlunma commented Jan 9, 2025

I still get the "invalid ancestor" error from clouds/clouds_ecs_groups_maps.py:

log.txt

@schlunma
Copy link
Contributor

schlunma commented Jan 9, 2025

Ah, and there is a WARNING Could not write HTML report: Some tags in the recipe could not be resolved: syntax error in line 13: premature end of file which prevents the index.html file to be written (which we need to get a nice overview of the results).

I am not quite sure what the problem is, I guess it's either a recipe problem (this warning appears in all 3 recipes) or a syntax error in the bibtex file you added (esmvaltool/references/bock24acp.bibtex).

@LisaBock
Copy link
Contributor Author

LisaBock commented Jan 9, 2025

Hi @schlunma , both issues should be solved now. In my tests, there are no warnings anymore.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lisa, looks good now! All recipes ran successful and their output looks good 🚀

@schlunma schlunma merged commit 818569f into main Jan 10, 2025
7 of 8 checks passed
@schlunma schlunma deleted the clouds_ecs_eval branch January 10, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding figures of Bock and Lauer (2024)
5 participants