move location of C++ generated files to generated/petsird and better CMake #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Together with an adaptation of our CMakeLists.txt, this means that we use `#include "petsird/types.h"` as opposed to `#include "generated/petsird.h"` WARNING: breaks backward compatibility
The petsird and petsird_helpers libraries simplify keeping track of include paths and dependencies. The latter now includes xtensor-blas as that is used in geometry.h. Fixes ETSInitiative#162
KrisThielemans
force-pushed
the
cpp_generated_location
branch
from
35e5118 to
648bd00
Compare
KrisThielemans
changed the title
KrisThielemans
commented
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
petsirdandpetsird_helpers(interface) libraries that keep track of include paths and dependenciesThis means that we use
#include "petsird/types.h"as opposed to#include "generated/petsird.h"WARNING: breaks backward compatibility!
Related issues
Fixes #128
Fixes #162
[x] The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in the ETSI software (the Work) under the terms and conditions of the Apache-2.0 License.