feat(441): Add Scroll Feature to Auth #447
Conversation
|
Hey made a new pr, the old one got closed so i made a new clean one, i updated my local version to the current main branch and just added my changes should be all good now! sorry for the hastle working with git gets big sometimes haha! |
|
looks good now from the first glance. Will review it later. Btw this is a checked checkbox in Markdown |
|
Understood keep me updated! |
|
Works good :) Just one thing: can you apply the 16px padding also on the bottom? There's currently no space when scrolling all way down: I think you can also apply the same padding to the headers tab |
SoulKa
changed the title
|
Alright ill add padding on both tabs |
|
there i added 16 px ofor auth, headers, and param. |
| <div className="pb-4"> | ||
| <Table className="w-full table-auto"> |
There was a problem hiding this comment.
I think you can simply add pb-4 to the Table instead of creating a new div here
There was a problem hiding this comment.
I tried that it didnt work
There was a problem hiding this comment.
So i opted to use a new div since adding that to existing ones did nothing
Changes
this pr fixes issue #441
added scroll feature to auth tab
Describe the changes of your PR here
Testing
checked to ensure it can scroll
If relevant, mention your manual testing here. If possible, include screenshots.
Checklist