Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More usages of JsonExtensionData; ParameterShovelValue #287

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

inikulshin
Copy link
Contributor

@inikulshin inikulshin commented Dec 21, 2023

@inikulshin
Copy link
Contributor Author

@Pliner I see that shorter PRs are completed faster. :)
Do you want me to split this one too?

@Pliner
Copy link
Member

Pliner commented Dec 24, 2023

Hey @inikulshin,

Sorry for the delay! I just need to find some time to review it, will try to do that today.

@inikulshin
Copy link
Contributor Author

inikulshin commented Dec 24, 2023

Hey @inikulshin,

Sorry for the delay! I just need to find some time to review it, will try to do that today.

I think that splitting this PR to smaller unrelated PRs is good idea.
I already created some and will create more.

So, this one should be abandoned.
Update: converted to draft.

@inikulshin inikulshin marked this pull request as draft December 24, 2023 14:24
@zidad
Copy link
Member

zidad commented Jan 4, 2024

Hi @inikulshin, is there anything left in this PR that isn't merged or can it be closed/abandoned?

Other question since you're contributing the most at the moment, are you interested in becoming a core contributor?

if you're interested let's discuss it in our slack channel please: https://easynetq.slack.com/

@inikulshin
Copy link
Contributor Author

@zidad the only things left are:

  1. Add missing GetQueuesWithoutStatsAsync variants (should be 4 like for GetQueuesAsync: [all | vhost] x [all | by page]
  2. Rename for #257

@inikulshin
Copy link
Contributor Author

Hi @inikulshin, is there anything left in this PR that isn't merged or can it be closed/abandoned?

Other question since you're contributing the most at the moment, are you interested in becoming a core contributor?

if you're interested let's discuss it in our slack channel please: https://easynetq.slack.com/

Do you need my email to invite me?

@zidad
Copy link
Member

zidad commented Jan 15, 2024

Hi @inikulshin, is there anything left in this PR that isn't merged or can it be closed/abandoned?
Other question since you're contributing the most at the moment, are you interested in becoming a core contributor?
if you're interested let's discuss it in our slack channel please: https://easynetq.slack.com/

Do you need my email to invite me?

Isn't it open to join for you?

@zidad
Copy link
Member

zidad commented Jan 17, 2024

Hi @inikulshin, is there anything left in this PR that isn't merged or can it be closed/abandoned?
Other question since you're contributing the most at the moment, are you interested in becoming a core contributor?
if you're interested let's discuss it in our slack channel please: https://easynetq.slack.com/

Do you need my email to invite me?

https://join.slack.com/t/easynetq/shared_invite/zt-2ar9kqe4j-AOHgfmRa0fLHJ~_I1TMzLg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants