Skip to content

Conversation

@jchen293
Copy link
Contributor

Description

Routes AmazonShippingAccount create/update requests to the new /register_oauth endpoint

Testing

Added new unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@ejachang ejachang marked this pull request as ready for review November 20, 2024 00:04
@ejachang ejachang requested a review from a team as a code owner November 20, 2024 00:04
@jchen293 jchen293 marked this pull request as draft November 20, 2024 00:06
@jchen293 jchen293 marked this pull request as ready for review December 17, 2024 17:48
@jchen293 jchen293 changed the title [WIP] Add Amazon shipping endpoint Add Amazon shipping endpoint Dec 17, 2024
Justintime50
Justintime50 previously approved these changes Dec 17, 2024
@jchen293 jchen293 requested a review from nwithan8 December 17, 2024 20:47
@jchen293 jchen293 marked this pull request as draft December 23, 2024 18:02
@jchen293
Copy link
Contributor Author

Putting this PR to draft until we finalize the update endpoint in Q1

@Justintime50
Copy link
Member

Shelving for now due to prioritization.

@Justintime50 Justintime50 reopened this Apr 10, 2025
@Justintime50 Justintime50 self-assigned this Apr 10, 2025
@Justintime50 Justintime50 marked this pull request as ready for review April 11, 2025 16:01
Copy link

@keheitz keheitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Justintime50 Justintime50 merged commit 3eff963 into master Apr 11, 2025
9 checks passed
@Justintime50 Justintime50 deleted the amazon_shipping branch April 11, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants