Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Maniacs Command 3009: ControlBattle #3295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MakoInfused
Copy link
Contributor

With all of these Control Battle events set:
image
image
image
image
image
image

Game developers have a way to inject events hooks into the battle system that might look something like this:
EasyRPG-ManiacsControlBattleCommand

This allows them to handle all kinds of events including:

  • ATB Changes (parallel process like event)
  • Health Changes (custom damage popup visualization)
  • Targets being selected (before turn event)
  • State Changes (custom status effects)
  • Other Stat Changes (custom stat change popup visualization)

One small difference from the maniacs version (Maniacs 210414) I use:
🐛 I unintentionally fixed a bug: when the battle begins in Maniacs, it only fire an event for the first state to change (or maybe it's just not waiting for the message box to close for the others?).
✅ In EasyRPG it will definitely provide the callback for all state changes, regardless of if it's at the beginning of the battle or during it and regardless of how many state changes happened. However, it works the same as maniacs in that it doesn't block the battle from ending in order to complete a callback.

Everything else should match identically.

My Testing Included:

  1. Every single variable value is sets before the callbacks.
  2. Every single callback.
  3. Every single callbacks handling of things that block it, such as event messages.

There was a lot to test with many different permutation combinations, so it's always possible something slipped. If so, please let me know. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants