Android & emscripten: Make buildscript work on m1 (arm64) macOS #196
+26
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires a newer NDK version which drops support for older Android SDKs <19. Though this is no problem for us as we already require API Level 20.
Ghabry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a newer NDK version which drops support for older Android SDKs <19.
Though this is no problem for us as we already require API Level 20.
For context: fdelapena set up a m1 mac. This will replace my awful, slow macOS builder.
The m1 is fast so I consider also offloading the Android build to it. The Android build is especially bad on our slow VPS because it compiles 4 times.
(then the main builder will only build Linux and emscripten)
This is a draft until the migration is done.
Emscripten was fixed because I finally have a test system available xD