add new arabic courses #6964

AhmedElTabarani · 2022-07-24T23:43:21Z

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

Read our contributing guidelines
Search for duplicates.
Include author(s) and platform where appropriate.
Put lists in alphabetical order, correct spacing.
Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

LuigiImVector

Missed some &rlm;

Also remember that atomic commits are prefered:

free-programming-books/docs/CONTRIBUTING.md

Line 55 in 88c2300

    
           - prefer atomic commits (one commit by addition/deletion/modification) over bigger commits. No need to squash your commits before submitting a PR. (We will never enforce this rule as it's just a matter of convenience for the maintainers)

LuigiImVector · 2022-07-25T10:23:43Z

courses/free-courses-ar.md

 * [Data Structure C++&lrm;&rlm;](https://www.youtube.com/playlist?list=PLsGJzJ8SQXTcsXRVviurGei0lf_t_I4D8) - Mega Code
 * [Data Structures Full Course In Arabic&rlm;](https://www.youtube.com/playlist?list=PLCInYL3l2AajqOUW_2SwjWeMwf4vL4RSp) - Adel Nasim
+* [Grokking Algorithms](https://www.youtube.com/playlist?list=PLWCr3KJclfzGV82gewnuAoKFBt_f9FvNa) - Programming Books


Suggested change

* [Grokking Algorithms](https://www.youtube.com/playlist?list=PLWCr3KJclfzGV82gewnuAoKFBt_f9FvNa) - Programming Books

* [Grokking Algorithms&rlm;](https://www.youtube.com/playlist?list=PLWCr3KJclfzGV82gewnuAoKFBt_f9FvNa) - Programming Books

LuigiImVector · 2022-07-25T10:24:39Z

courses/free-courses-ar.md

@@ -113,6 +117,7 @@
 * [CS Master - Level 3 - Databases قواعد البيانات](https://www.youtube.com/playlist?list=PLL2zWZTDFZzhXQ1bcYlO3PtN4MsLiG-gy) - KMR Script
 * [Database 1 - المقرر النظرى - Fundamentals of Database Systems](https://www.youtube.com/playlist?list=PL37D52B7714788190) - محمد الدسوقى
 * [Database Design](https://www.youtube.com/playlist?list=PLkzDzmo9y3VHDFKp7LuXd-FwbefvTL5o0) - تخاريف مبرمج
+* [Designing Data Intensive Applications](https://www.youtube.com/playlist?list=PLTRDUPO2OmIljJwE9XMYE_XEgEIWZDCuQ) - Ahmed Elemam


Suggested change

* [Designing Data Intensive Applications](https://www.youtube.com/playlist?list=PLTRDUPO2OmIljJwE9XMYE_XEgEIWZDCuQ) - Ahmed Elemam

* [Designing Data Intensive Applications&rlm;](https://www.youtube.com/playlist?list=PLTRDUPO2OmIljJwE9XMYE_XEgEIWZDCuQ) - Ahmed Elemam

LuigiImVector · 2022-07-25T10:25:12Z

courses/free-courses-ar.md

@@ -170,6 +175,7 @@
 * [Learn SASS In Arabic 2021&rlm;](https://www.youtube.com/playlist?list=PLDoPjvoNmBAzlpyFHOaB3b-eubmF0TAV2) - Elzero Web School
 * [Sass&rlm;](https://www.youtube.com/playlist?list=PLDoPjvoNmBAz6bF7qObm2a1mLN_WHAWQo) - Elzero Web School
 * [Sass - Create a website&rlm;](https://www.youtube.com/playlist?list=PLDoPjvoNmBAz9sluuyOWPifXvySgrGma8) - Elzero Web School
+* [Yonisfy CS94's | Web Programming with JavaScript](https://www.youtube.com/playlist?list=PLLWuK602vNiXqkUqcoKrVjCyOrZh7Tw0e) - Mohammed Elzanaty


Suggested change

* [Yonisfy CS94's | Web Programming with JavaScript](https://www.youtube.com/playlist?list=PLLWuK602vNiXqkUqcoKrVjCyOrZh7Tw0e) - Mohammed Elzanaty

* [Yonisfy CS94's | Web Programming with JavaScript&rlm;](https://www.youtube.com/playlist?list=PLLWuK602vNiXqkUqcoKrVjCyOrZh7Tw0e) - Mohammed Elzanaty

LuigiImVector · 2022-07-25T10:27:09Z

courses/free-courses-ar.md

 * [كورس Ajax بالعربي-ITI&rlm;](https://www.youtube.com/playlist?list=PLzCpl3aBwaY7wv9ZZkhH7lZELpz_fP81N) - Mobarmg
 * [كورس ES6 بالعربي-ITI&rlm;](https://www.youtube.com/playlist?list=PLzCpl3aBwaY5nQxWH0HaNibR9UXKICWxz) - Mobarmg
 * [Arabic JavaScript&rlm;](https://www.youtube.com/playlist?list=PLL2zWZTDFZzgU2x6Kk6w0qx5piLgMODsm) - KMR Script
 * [Arabic JavaScript ES6 الاصدار السادس من الجافاسكربت](https://www.youtube.com/playlist?list=PLL2zWZTDFZzilx_LJ_mCRDETtDOyBg0UT) - KMR Script
+* [Complete Intro to Javascript&rlm;](https://www.youtube.com/playlist?list=PLLWuK602vNiU-kIpNuw5Z7HRbV4pBaHlL) - Mohammed Elzanaty
+* [Design Patterns \| javascript \| [Arabic]&rlm;](https://www.youtube.com/playlist?list=PLS-MrzRLZtmduTfp_bReagQKg7I-GVr-5) - Shadow Coding


Suggested change

* [Design Patterns \| javascript \| [Arabic]&rlm;](https://www.youtube.com/playlist?list=PLS-MrzRLZtmduTfp_bReagQKg7I-GVr-5) - Shadow Coding

* [Design Patterns \| javascript \| \[Arabic\]&rlm;](https://www.youtube.com/playlist?list=PLS-MrzRLZtmduTfp_bReagQKg7I-GVr-5) - Shadow Coding

The square brackets must be escaped also ?

could create conflicts with those in the link

LuigiImVector · 2022-07-25T10:35:15Z

courses/free-courses-ar.md

@@ -336,6 +350,8 @@
 * [Clean Code Book - بالعربي](https://www.youtube.com/playlist?list=PLwWuxCLlF_ufTMlXoJlQvImqz9wIfcWsX) - Omar Ahmed
 * [Creational Design Patterns بالعربى](https://www.youtube.com/playlist?list=PLnqAlQ9hFYdewk9UKGBcHLulZNUBpNSKJ) - Mohammed Reda
 * [Declarative Programming](https://www.youtube.com/playlist?list=PLpbZuj8hP-I6F-Zj1Ay8nQ1rMnmFnlK2f) - درة الاكواد لابن حماد
+* [Head First Object-Oriented Analysis and Design&rlm;](https://www.youtube.com/playlist?list=PLWCr3KJclfzGkG7CXBmSdlIcIpjxo4FbF) - Programming Books
+* [Software Design Patterns](https://www.youtube.com/playlist?app=desktop&list=PLrwRNJX9gLs3oQyBoXtYimY7M5aSF0_oC) - محمد يحيى


Suggested change

* [Software Design Patterns](https://www.youtube.com/playlist?app=desktop&list=PLrwRNJX9gLs3oQyBoXtYimY7M5aSF0_oC) - محمد يحيى

* [Software Design Patterns&rlm;](https://www.youtube.com/playlist?app=desktop&list=PLrwRNJX9gLs3oQyBoXtYimY7M5aSF0_oC) - محمد يحيى

No need to add &rlm; here
the author name in Arabic, so the context will not swap

I didn't know that, could you add it to #6964?

#6964 ? You miss the issue?

If you mean this #6714, this only for problems

* [name in english](url) - name in arabic
That not cause any problem

If you mean this #6714

ops, i confused id

That not cause any problem

maybe you could add it just for clarification, in an "extra case 2"

maybe you could add it just for clarification, in an "extra case 2"

done

AhmedElTabarani · 2022-07-25T13:16:42Z

I will delete Head First Object-Oriented Analysis and Design, Grokking Algorithms, Designing Data Intensive Applications

Because it does courses to explain paid books as @eshellman said here #6764

AhmedElTabarani · 2022-07-25T17:53:25Z

@eshellman, relying on a paid book to explain is illegal? Or explain the book itself is illegal?

Because most of the courses depend on paid books such as clean code courses

eshellman · 2022-07-25T18:20:21Z

What do you think - Is it a free course if the book isn't free? Many courses are taught so they don't really need the book, but maybe these really rely heavily on the not-free book? The test is: does the course stand on its own? We have to rely on you to make the judgement.

AhmedElTabarani · 2022-07-30T22:36:51Z

courses/free-courses-ar.md

@@ -170,6 +173,7 @@
 * [Learn SASS In Arabic 2021&rlm;](https://www.youtube.com/playlist?list=PLDoPjvoNmBAzlpyFHOaB3b-eubmF0TAV2) - Elzero Web School
 * [Sass&rlm;](https://www.youtube.com/playlist?list=PLDoPjvoNmBAz6bF7qObm2a1mLN_WHAWQo) - Elzero Web School
 * [Sass - Create a website&rlm;](https://www.youtube.com/playlist?list=PLDoPjvoNmBAz9sluuyOWPifXvySgrGma8) - Elzero Web School
+* [Yonisfy CS94's | Web Programming with JavaScript&rlm;](https://www.youtube.com/playlist?list=PLLWuK602vNiXqkUqcoKrVjCyOrZh7Tw0e) - Mohammed Elzanaty


I forget escape |, we need a regex to check these mistakes if a '|' have an escape character '\' or not, or something like this.

This issue is discussed on #5176

AhmedElTabarani added 3 commits July 25, 2022 01:41

add new arabic courses

3e30b0e

fix extra new line

2cbe7eb

fix order

92d2866

AhmedElTabarani force-pushed the add-arabic-courses branch from e67f9f6 to 92d2866 Compare July 24, 2022 23:51

LuigiImVector reviewed Jul 25, 2022

View reviewed changes

LuigiImVector assigned AhmedElTabarani Jul 25, 2022

LuigiImVector added waiting for changes PR has been reviewed and changes/suggestions requested 🗣️ locale:ar Resources addressing "Arabic / العربية" language labels Jul 25, 2022

add some missing &rlm;

302ff01

AhmedElTabarani mentioned this pull request Jul 25, 2022

Some questions #6764

Closed

7 tasks

delete courses that dependent on paid books

df3ec36

eshellman requested a review from LuigiImVector July 26, 2022 06:48

LuigiImVector approved these changes Jul 26, 2022

View reviewed changes

LuigiImVector added 🚀 ready to merge LGTM. Waiting for final approval and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Jul 26, 2022

eshellman merged commit 19958fb into EbookFoundation:main Jul 27, 2022

AhmedElTabarani deleted the add-arabic-courses branch July 27, 2022 18:34

AhmedElTabarani commented Jul 30, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add new arabic courses #6964

add new arabic courses #6964

AhmedElTabarani commented Jul 24, 2022

LuigiImVector left a comment

LuigiImVector Jul 25, 2022

LuigiImVector Jul 25, 2022

LuigiImVector Jul 25, 2022

LuigiImVector Jul 25, 2022

AhmedElTabarani Jul 25, 2022

LuigiImVector Jul 25, 2022 •

edited

Loading

LuigiImVector Jul 25, 2022

AhmedElTabarani Jul 25, 2022

AhmedElTabarani Jul 25, 2022

LuigiImVector Jul 25, 2022

AhmedElTabarani Jul 25, 2022

AhmedElTabarani Jul 25, 2022 •

edited

Loading

LuigiImVector Jul 25, 2022

AhmedElTabarani Jul 25, 2022

AhmedElTabarani commented Jul 25, 2022

AhmedElTabarani commented Jul 25, 2022

eshellman commented Jul 25, 2022

AhmedElTabarani Jul 30, 2022 •

edited

Loading

LuigiImVector Jul 31, 2022

	* [Grokking Algorithms](https://www.youtube.com/playlist?list=PLWCr3KJclfzGV82gewnuAoKFBt_f9FvNa) - Programming Books
	* [Grokking Algorithms&rlm;](https://www.youtube.com/playlist?list=PLWCr3KJclfzGV82gewnuAoKFBt_f9FvNa) - Programming Books

	* [Designing Data Intensive Applications](https://www.youtube.com/playlist?list=PLTRDUPO2OmIljJwE9XMYE_XEgEIWZDCuQ) - Ahmed Elemam
	* [Designing Data Intensive Applications&rlm;](https://www.youtube.com/playlist?list=PLTRDUPO2OmIljJwE9XMYE_XEgEIWZDCuQ) - Ahmed Elemam

	* [Yonisfy CS94's \| Web Programming with JavaScript](https://www.youtube.com/playlist?list=PLLWuK602vNiXqkUqcoKrVjCyOrZh7Tw0e) - Mohammed Elzanaty
	* [Yonisfy CS94's \| Web Programming with JavaScript&rlm;](https://www.youtube.com/playlist?list=PLLWuK602vNiXqkUqcoKrVjCyOrZh7Tw0e) - Mohammed Elzanaty

	* [Design Patterns \\| javascript \\| [Arabic]&rlm;](https://www.youtube.com/playlist?list=PLS-MrzRLZtmduTfp_bReagQKg7I-GVr-5) - Shadow Coding
	* [Design Patterns \\| javascript \\| \[Arabic\]&rlm;](https://www.youtube.com/playlist?list=PLS-MrzRLZtmduTfp_bReagQKg7I-GVr-5) - Shadow Coding

	* [Software Design Patterns](https://www.youtube.com/playlist?app=desktop&list=PLrwRNJX9gLs3oQyBoXtYimY7M5aSF0_oC) - محمد يحيى
	* [Software Design Patterns&rlm;](https://www.youtube.com/playlist?app=desktop&list=PLrwRNJX9gLs3oQyBoXtYimY7M5aSF0_oC) - محمد يحيى

add new arabic courses #6964

add new arabic courses #6964

Conversation

AhmedElTabarani commented Jul 24, 2022

What does this PR do?

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

Follow-up

LuigiImVector left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LuigiImVector Jul 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AhmedElTabarani Jul 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AhmedElTabarani commented Jul 25, 2022

AhmedElTabarani commented Jul 25, 2022

eshellman commented Jul 25, 2022

AhmedElTabarani Jul 30, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LuigiImVector Jul 25, 2022 •

edited

Loading

AhmedElTabarani Jul 25, 2022 •

edited

Loading

AhmedElTabarani Jul 30, 2022 •

edited

Loading