This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: admin user check middleware #9249
Merged
eddiejaoude
merged 4 commits into
EddieHubCommunity:feat-middleware
from
bikrantjajware:feat/middleware
Oct 17, 2023
Merged
feat: admin user check middleware #9249
eddiejaoude
merged 4 commits into
EddieHubCommunity:feat-middleware
from
bikrantjajware:feat/middleware
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiejaoude
reviewed
Oct 1, 2023
eddiejaoude
reviewed
Oct 1, 2023
eddiejaoude
suggested changes
Oct 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution 👍
I have added some inline comments
Hello Eddie, |
Hello @eddiejaoude, |
Sorry for my delay, I will have a look soon. It looks like the automated tests are passing which is great 👍 |
eddiejaoude
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
eddiejaoude
merged commit Oct 17, 2023
853cf0b
into
EddieHubCommunity:feat-middleware
13 checks passed
Thank you Eddie :) |
6 tasks
eddiejaoude
added a commit
that referenced
this pull request
Oct 24, 2023
* feat: admin user check middleware (#9249) * feat: admin check middleware * fix review comments * match /api/admin paths --------- Co-authored-by: Eddie Jaoude <[email protected]> * feat: authenticated pages protected * fix: removed session checks from account pages * test: home page stats #9384 (#9462) * Update home.spec.js * Update home.spec.js * Update home.spec.js * Update home.spec.js * Update tests/home.spec.js * Update tests/home.spec.js --------- Co-authored-by: Eddie Jaoude <[email protected]> * feat: sentry integration (#9187) * chore(release): v2.76.0 [skip ci] * fix: sentry disable cron (#9533) * fix: sentry disable cron * fix: test setup error var * chore(release): v2.76.1 [skip ci] * deploy to prevew * fix: removed debug code --------- Co-authored-by: Bikrant Jajware <[email protected]> Co-authored-by: Ken Beaudin <[email protected]> Co-authored-by: Conventional Changelog Action <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #8389
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers
NOTE: