-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: add tags to events #9276
feat: add tags to events #9276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey dunsin! Looking good so far. I have a few notes and one oddity that may be due to my environment but will require another maintainer to test.
- In adding the tags, the UI form for adding an event has been altered. Please maintain the 1-column layout for now as no design changes should be part of this issue. If you would like to propose design changes here, we can handle that separately.
- The labels for are missing in the add event form
- When I was testing, although I can add an event and see the tags in the preview, on save I cannot see them live. This may be my environment as I had issues on another PR related to events seeing the updates (testing in gitpod) - needs confirmation from another maintainer
- attempted testing to see what happens when duplicate URL events with different tags are merged - unsuccessful due to the issue above.
Images for clarity - please let me know if you need any more detail. Thank you for working on this.
@amandamartin-dev for the review:
|
For point 1 - you have added a new div but if you take a look at the structure of the form, the CSS on the new div is different - this is likely the culprit. Take a look and see what you find and if you are stuck, I can help a little later.
|
Interesting because that's how it looked like when I did run it the first time without adding anything🤔 but it could also be from me I'm going to do two things: check the PR code for anything that I know for a fact I didn't add, the second thing would be to go to the code and uncomment the JSX change I did, if it makes a difference or it doesn't I will let you know. |
Co-authored-by: Eddie Jaoude <[email protected]>
I'm off the coding grid atm so couldn't do anything, thanks for the help @eddiejaoude |
No worries @Dun-sin |
return null; | ||
} | ||
|
||
return <Tag name={trimmedTag} key={index} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
I will address the remaining comments via a temporary branch
I will address via temporary branch
* feat: tags to events (#9276) * feat: add tags while creating a new event and send it to the api * feat: add tags to events * chore: remove package-lock.json * Update pages/account/manage/event/[[...data]].js Co-authored-by: Eddie Jaoude <[email protected]> --------- Co-authored-by: Eddie Jaoude <[email protected]> * fix: tags to events --------- Co-authored-by: Dunsin <[email protected]>
Fixes Issue
Closes #5832
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers