Fixes Using Chips in the "add Tags" section #9103 #9508

Zopsss · 2023-10-15T09:49:35Z

Fixes Issue

Fixes #9103

Changes proposed

Added "enter" functionality to the "Tags" input, now we can add new tags by pressing "enter".

Screenshots

2023-10-15.14-57-01.mp4

This reverts commit 553bed8.

kumarsonsoff3

PRs not related to profile, should not include any data file. Also, you're not allowed to remove someone else json file.

Please revert the changes from data/alevel7.json

This reverts commit 8ba32c0.

Zopsss · 2023-10-16T04:57:37Z

PRs not related to profile, should not include any data file. Also, you're not allowed to remove someone else json file.

Please revert the changes from data/alevel7.json

I reverted that commit and pushed the new changes. Sorry for accidently deleting someone's json file.

pages/account/manage/profile.js

eddiejaoude · 2023-10-21T08:19:15Z

components/tag/TagsInput.js

 import XMarkIcon from "@heroicons/react/20/solid/XMarkIcon";
 import Input from "../form/Input";

-export default function TagsInput({ tags, onTagAdd, onTagRemove }) {
-  const inputRef = useRef(null);
+export default function TagsInput({ tags, onTagAdd, onTagRemove, tagInputRef }) {


If this name was kept the same there would be less changes in the file. I think `inputRef is still descriptive in the scope of this function

so should I the tagInputref to inputRef?

Yes please 👍

This has been fixed

eddiejaoude

Thank you for your contribution 👍 But this now breaks the events page, please search for where the component TagsInput is used

Zopsss · 2023-10-21T13:34:17Z

Thank you for your contribution 👍 But this now breaks the events page, please search for where the component TagsInput is used

can you specify steps to produce this error?

eddiejaoude · 2023-10-21T13:38:46Z

can you specify steps to produce this error?

I clicked on manage events, then went to edit an event. You can search for where the TagsInput component is used, then you can test these pages also

… UsingChips#9103

Zopsss · 2023-10-21T14:19:55Z

can you specify steps to produce this error?

I clicked on manage events, then went to edit an event. You can search for where the TagsInput component is used, then you can test these pages also

in my local setup there is no option to add tags on events and VS Code is showing that TagsInput is only used in profile.js file. I also pulled changes but the tags options on event manage page is still not showing.

badrivlog · 2023-10-21T16:36:29Z

in my local setup there is no option to add tags on events and VS Code is showing that TagsInput is only used in profile.js file. I also pulled changes but the tags options on event manage page is still not showing.

see screen recording below to reproduce the error

Onboarding.Dashboard.-.Google.Chrome.mp4

… UsingChips#9103

…ioDrop into UsingChips#9103

badrivlog · 2023-10-26T14:07:51Z

pages/account/manage/event/[[...data]].js

@@ -57,6 +57,7 @@ export default function ManageEvent({ BASE_URL, event }) {
  const [endDate, setEndDate] = useState("");
  const [speakingTopic, setspeakingTopic] = useState(event.speakingTopic || "");
  const [tags, setTags] = useState(event.tags || []);
+  const inputRef = useRef(null);


I'm not sure why this variable named inputRef. I think naming the variable simply inputRef might not be very descriptive, because I see in the scope of this function has multiple input fields.

Yep 👍 Inside the tag component it can be inputRef but outside it should be tagInputRef

Yeah that makes sense

sorry for the late reply, I made the changes as you requested and pushed the changes.

badrivlog · 2023-10-26T14:08:31Z

pages/account/manage/profile.js

@@ -76,6 +76,8 @@ export default function Profile({ BASE_URL, profile, fileExists }) {
    };
  });

+  const inputRef = useRef(null);


… UsingChips#9103

…ioDrop into UsingChips#9103

eddiejaoude · 2023-11-02T08:00:45Z

pages/account/manage/event/[[...data]].js

@@ -105,6 +106,10 @@ export default function ManageEvent({ BASE_URL, event }) {
  const handleSubmit = async (e) => {
    e.preventDefault();

+    if (document.activeElement === tagInputRef.current) {
+      console.log('testing');


Please remove debug code

Sorry I forgot to remove it before now I've removed it and pushed the changes. Thanks for addressing this.

badrivlog

Looks good to me👍

eddiejaoude

Thank you 👍

eddiejaoude

Sorry I was meant to approve

Zopsss added 2 commits October 15, 2023 14:22

Revert "data: alevel7 (EddieHubCommunity#9459)"

8ba32c0

This reverts commit 553bed8.

Fixes EddieHubCommunity#9103 Using Chips in the 'add Tags'

60cf8a2

github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition issue linked Pull Request has issue linked labels Oct 15, 2023

kumarsonsoff3 previously requested changes Oct 15, 2023

View reviewed changes

Revert "Revert "data: alevel7 (EddieHubCommunity#9459)""

4558d00

This reverts commit 8ba32c0.

github-actions bot removed invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Oct 16, 2023

badrivlog reviewed Oct 16, 2023

View reviewed changes

pages/account/manage/profile.js Outdated Show resolved Hide resolved

Renamed inputRef to tagInputRef

520eb4c

schmelto approved these changes Oct 19, 2023

View reviewed changes

eddiejaoude reviewed Oct 21, 2023

View reviewed changes

Merge branch 'main' into UsingChips#9103

8733641

eddiejaoude suggested changes Oct 21, 2023

View reviewed changes

Zopsss added 3 commits October 21, 2023 19:26

renamed tagInputRef to inputRef

cf5ca14

Merge branch 'main' of https://github.com/MauryanKansara/BioDrop into…

3e98cdd

… UsingChips#9103

Merge branch 'main' of https://github.com/MauryanKansara/BioDrop into…

8ed31d1

… UsingChips#9103

Zopsss and others added 6 commits October 22, 2023 14:50

Merge branch 'main' of https://github.com/MauryanKansara/BioDrop into…

ca711f7

… UsingChips#9103

Merge branch 'main' of https://github.com/MauryanKansara/BioDrop into…

00847f5

… UsingChips#9103

solved 'inputRef.current is undefined' error on manage events page

4be616c

Merge branch 'main' of https://github.com/MauryanKansara/BioDrop into…

780390d

… UsingChips#9103

Merge branch 'main' into UsingChips#9103

d848495

Merge branch 'UsingChips#9103' of https://github.com/MauryanKansara/B…

e458552

…ioDrop into UsingChips#9103

badrivlog reviewed Oct 26, 2023

View reviewed changes

Zopsss added 3 commits October 31, 2023 21:52

Merge branch 'main' of https://github.com/MauryanKansara/BioDrop into…

d2fa621

… UsingChips#9103

renamed inputRef to tagInputRef in profile.js and [[...data]].js files

08ad5d6

Merge branch 'UsingChips#9103' of https://github.com/MauryanKansara/B…

2eb3d15

…ioDrop into UsingChips#9103

eddiejaoude reviewed Nov 2, 2023

View reviewed changes

removed debug code

8334b43

badrivlog approved these changes Nov 6, 2023

View reviewed changes

SaraJaoude mentioned this pull request Nov 12, 2023

[BUG] React Hook useEffect has a missing dependency in ./pages/search.js #9006

Closed

eddiejaoude suggested changes Nov 17, 2023

View reviewed changes

eddiejaoude approved these changes Nov 17, 2023

View reviewed changes

eddiejaoude merged commit 978bc1a into EddieHubCommunity:main Nov 17, 2023
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes Using Chips in the "add Tags" section #9103 #9508

Fixes Using Chips in the "add Tags" section #9103 #9508

Zopsss commented Oct 15, 2023 •

edited by eddiejaoude

Loading

kumarsonsoff3 left a comment

Zopsss commented Oct 16, 2023

eddiejaoude Oct 21, 2023

Zopsss Oct 21, 2023

eddiejaoude Oct 21, 2023

eddiejaoude left a comment •

edited

Loading

Zopsss commented Oct 21, 2023

eddiejaoude commented Oct 21, 2023 •

edited

Loading

Zopsss commented Oct 21, 2023

badrivlog commented Oct 21, 2023

badrivlog Oct 26, 2023

eddiejaoude Oct 27, 2023

badrivlog Oct 27, 2023

Zopsss Oct 31, 2023

badrivlog Oct 26, 2023

eddiejaoude Nov 2, 2023

Zopsss Nov 3, 2023

badrivlog left a comment

eddiejaoude left a comment

eddiejaoude left a comment

Fixes Using Chips in the "add Tags" section #9103 #9508

Fixes Using Chips in the "add Tags" section #9103 #9508

Conversation

Zopsss commented Oct 15, 2023 • edited by eddiejaoude Loading

Fixes Issue

Changes proposed

Screenshots

kumarsonsoff3 left a comment

Choose a reason for hiding this comment

Zopsss commented Oct 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eddiejaoude left a comment • edited Loading

Choose a reason for hiding this comment

Zopsss commented Oct 21, 2023

eddiejaoude commented Oct 21, 2023 • edited Loading

Zopsss commented Oct 21, 2023

badrivlog commented Oct 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

badrivlog left a comment

Choose a reason for hiding this comment

eddiejaoude left a comment

Choose a reason for hiding this comment

eddiejaoude left a comment

Choose a reason for hiding this comment

Zopsss commented Oct 15, 2023 •

edited by eddiejaoude

Loading

eddiejaoude left a comment •

edited

Loading

eddiejaoude commented Oct 21, 2023 •

edited

Loading