Sam/ethereum plugin fixes #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
swansontec
approved these changes
Jul 11, 2025
samholmes
force-pushed
the
sam/ethereum-plugin-fixes
branch
from
a7ba0e2 to
b8cfeb1
Compare
By catching unknown errors in the acquireUpdates function, the caller doesn't know that the function failed and will retry after snoozing. The wallet would be stuck in this loop thrashing the network and degrading device performance while the app is in a buggy state because of the unknown error. Instead, we'll break out of the syncNetwork function because the unknown error is actually thrown. The core should log errors from syncNetwork to be introspected by a developer when debugging.
The first problem solved with this change is to have a dedicated `highestTxBlockHeight` state which tracks the blockHeight of the last transaction received. This would more accurately determine whether a change is present on the network and eliminate missing transaction bugs. The second fix is to increase the immediacy of the call to `onSubscribeAddresses` callback. This gets the subscription request to the core sooner, minimizing the race for the core to start the `PeriodicTask` version of `syncNetwork`.
samholmes
force-pushed
the
sam/ethereum-plugin-fixes
branch
from
b8cfeb1 to
3271dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none