feat: Add OS and app version details to core context #5895
Conversation
Pass appVersion, osType, and osVersion to EdgeContextOptions for use with the v2/coreRollup endpoint.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "detect-bundler": "^1.1.0", | ||
| "disklet": "^0.5.2", | ||
| "edge-core-js": "^2.38.2", | ||
| "edge-core-js": "../edge-core-js", |
There was a problem hiding this comment.
Local path dependency accidentally committed to package.json
High Severity
The edge-core-js dependency was changed from the npm version "^2.38.2" to a local file path "../edge-core-js". This is development code that will break the build for any other developer or CI/CD system, as the local path won't exist on other machines. The yarn.lock also reflects this local dependency. This needs to be reverted to point to a published npm version (likely the new version with appVersion, osType, and osVersion support).
There was a problem hiding this comment.
Yes, please update & rebase before committing.
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
Just one common mistake - the React.FC thing.
| * once the core context is ready. | ||
| */ | ||
| export function EdgeCoreManager(props: Props) { | ||
| export function EdgeCoreManager(props: Props): React.JSX.Element { |
There was a problem hiding this comment.
This should be export const EdgeCoreManager: React.FC<Props> = props =>
| "detect-bundler": "^1.1.0", | ||
| "disklet": "^0.5.2", | ||
| "edge-core-js": "^2.38.2", | ||
| "edge-core-js": "../edge-core-js", |
There was a problem hiding this comment.
Yes, please update & rebase before committing.
Pass appVersion, osType, and osVersion to EdgeContextOptions for use with the v2/coreRollup endpoint.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Adds app and OS version metadata to the core context and updates dependencies accordingly.
EdgeCoreManager, passappVersion,osType, andosVersioninEdgeContextOptions(addsPlatform,getVersion,getOsVersionimports and minor type annotations)edge-core-jsdependency to local path (../edge-core-js); refreshyarn.lockCHANGELOGentry for the new metadataWritten by Cursor Bugbot for commit 5f08edc. This will update automatically on new commits. Configure here.