DOES NOT WORK. Non-working stdin implementation. #1296
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how a naive web-based stdin implementation would look like, except that the web worker doesn't have a way of "waiting" for the data to come from the UI. A better solution would probably be event-based, but I am unsure if it can be implemented without changing more deeply the simulator logic and the way it interacts with I/O.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1296 +/- ##
=========================================
Coverage 52.29% 52.29%
Complexity 1468 1468
=========================================
Files 252 252
Lines 10261 10261
Branches 1105 1105
=========================================
Hits 5366 5366
Misses 4572 4572
Partials 323 323
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@davidepatti suggests to implement a new CPU state to represent waiting for the input, which makes total sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how a naive web-based stdin implementation would look like, except that the web worker doesn't have a way of "waiting" for the data to come from the UI.
A better solution would probably be event-based,
but I am unsure if it can be implemented without
changing more deeply the simulator logic and the way it interacts with I/O.