-
Notifications
You must be signed in to change notification settings - Fork 0
Evaluating new clustering + sensor model #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
<param name="use_sim_time" value="$(var use_sim_time)" /> | ||
</node> --> | ||
|
||
</launch> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end of line.
161941a
to
f16f08b
Compare
Signed-off-by: Gerardo Puga <[email protected]>
Signed-off-by: Gerardo Puga <[email protected]>
…e intervals Signed-off-by: Gerardo Puga <[email protected]>
f16f08b
to
7399f6d
Compare
This PR follows the tests and updates used to teset Ekumen-OS/beluga#476 (comment) Unfortunately, the PR now has conflicts with main that would be unwise to fix in a hurry given that testing the changes would require at least doing a partial run and rebuild of the testbench, so this will have to wait until I'm back to move forward. Regardless, this needs Ekumen-OS/beluga#476 to be merged before being merged, because it assumes the new sensor model to be available. |
This is the report produced by this version (except for this report the 24hs dataset was not used): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
@@ -1,80 +1,227 @@ | |||
<launch> | |||
<arg name="map_filename"/> | |||
<arg name="map_filename" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glpuga meta: why adding these spaces? Google yields some XHTML connection to this formatting style that I don't think is relevant here.
beluga_amcl_likelihood_cpu_util = "???" | ||
beluga_amcl_likelihood_peak_rss = "???" | ||
beluga_amcl_likelihood_prob_cpu_util = "???" | ||
beluga_amcl_likelihood_prob_peak_rss = "???" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glpuga meta: we really need a better way to deal with partial benchmark runs than these huge try...except
blocks.
Proposed changes
Note: this needs Ekumen-OS/beluga#476 to be merged before, because it assumes the new sensor model to be available.
This PR merges into the main Beluga evaluation report changes created to evaluate the impact of Ekumen-OS/beluga#476
Type of change
💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.
Checklist
Put an
x
in the boxes that apply. This is simply a reminder of what we will require before merging your code.Additional comments
Anything worth mentioning to the reviewers.