build (macos): do not overwrite PKG_CONFIG_PATH variable#8146
Merged
rustyrussell merged 1 commit intoElementsProject:masterfrom Nov 11, 2025
Merged
build (macos): do not overwrite PKG_CONFIG_PATH variable#8146rustyrussell merged 1 commit intoElementsProject:masterfrom
PKG_CONFIG_PATH variable#8146rustyrussell merged 1 commit intoElementsProject:masterfrom
Conversation
vincenzopalazzo
approved these changes
Mar 7, 2025
rustyrussell
force-pushed
the
configure
branch
from
cca721a to
61c5582
Compare
Contributor
sangbida
approved these changes
Oct 2, 2025
sangbida
reviewed
Oct 2, 2025
Collaborator
sangbida
left a comment
sangbida
left a comment
There was a problem hiding this comment.
It compiles fine on my machine, although I would've liked a better PR description or commit message. The PR that this points to in homebrew seems to be a closed PR. I would've liked to replicate the issue this PR is solving and see what it fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
25.02 FREEZE JANUARY 31ST: Non-bugfix PRs not ready by this date will wait for 25.05.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
macOS configure script overwrites user provided PKG_CONFIG_PATH instead of appending to it
fixes Homebrew/homebrew-core/pull/210080