Skip to content

Conversation

@whitslack
Copy link
Collaborator

I noticed a typo in cln-rpc/Makefile while trying to hunt down why Make was remaking targets.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

@whitslack whitslack requested a review from cdecker as a code owner April 5, 2025 05:46
@whitslack
Copy link
Collaborator Author

Also, shouldn't cln-grpc/Makefile be included from somewhere? It's not. Thus, make cln-grpc-all leads to…

make: *** No rule to make target 'cln-grpc-all'.  Stop.

It looks like include cln-grpc/Makefile should go inside the ifneq ($(RUST),0) block in the root Makefile.

@cdecker
Copy link
Member

cdecker commented Apr 21, 2025

All good changes, thanks for fixing them ^^

ACK d3d034b

@cdecker cdecker enabled auto-merge (rebase) April 21, 2025 15:14
@cdecker cdecker merged commit e0ded49 into ElementsProject:master Apr 21, 2025
39 of 40 checks passed
@ShahanaFarooqui ShahanaFarooqui added this to the v25.05 milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants