Upgrade Cargo.lock to version=4
#8265
Conversation
cctools have been moved into the darwin system packages Signed-off-by: Peter Neuroth <[email protected]>
Update Cargo.lock and nixpkgs to support current stable rust releases. We need to update as upgrading rustc past v1.77 changes the syntax used in for the lockfile. Changelog-None Signed-off-by: Peter Neuroth <[email protected]>
nepet
force-pushed
the
2518-upgrade-cargo-version
branch
from
5a4388d to
469b332
Compare
|
I don't quite understand what you mean by "upgrading lock file version allows using the stable toolchain". You can use version 3 just fine with the most up to date stable rust 1.86. But this would raise the minimum required rust version to 1.78, raising it from CLN's current 1.75. |
|
While it is true that cargo 1.86 is backwards compatible, the problem I headed into a couple of times so far is, that if you add a new dependency or update an existing one using any version post 1.77 the version of the lockfile will get updated (if you forget to specify the correct toolchain). The intension of this PR is to make this change visible instead of hiding it in some other PR that updates or adds a crate. Is there a reason I am not aware of, why we want to keep staying on this specific version of rust, which is EOL since 1 year (nixpkgs v24.05 only got security updates until dec 2024 as well)? |
|
A few more users must install rustup since their package manager doesn't have a more recent version of rust. CLN seems to be focused on ubuntu a little and both ubuntu LTS versions 22.04 and 24.04 ship with 1.75. But if you ask me alot of people do that already and have to even, all stable debian versions ship with <1.70 for example. So if you ask me, go hard or go home: MSRV=latest stable 😄 |
|
Btw to build all our dependency tree after running cargo update right now we would need atleast 1.82 |
|
|
2 participants
This PR upgrades
Cargo.lockto version4. The lockfile version has changed with cargov1.78. Upgrading allows to use thestabletoolchain which is abovev1.77.This includes upgading
nixpkgsto a version that includes newer versions ofrustc.