splice: Adjust batch_size TLV to match Eclair’s#8289
Merged
endothermicdev merged 1 commit intoElementsProject:masterfrom May 15, 2025
Merged
splice: Adjust batch_size TLV to match Eclair’s#8289endothermicdev merged 1 commit intoElementsProject:masterfrom
batch_size TLV to match Eclair’s#8289endothermicdev merged 1 commit intoElementsProject:masterfrom
Conversation
remyers
suggested changes
May 15, 2025
Contributor
remyers
left a comment
remyers
left a comment
There was a problem hiding this comment.
Need to add some checks to avoid crashes.
Eclair only sets `batch_size` and `funding_txid` when its a batch larger than 1. Adjust how we send and what we expect to receive to match this. Changelog-None
ddustin
force-pushed
the
ddustin/batch_size_tlv
branch
from
b7aac40 to
cca076b
Compare
remyers
added a commit
to remyers/lightning-cfg
that referenced
this pull request
May 15, 2025
Had to also apply my own version of ElementsProject/lightning#8289 to fix crashes, but should be the same as the final.
Contributor
|
My tests are passing with my own (essentially identical) changes on top of master. |
Contributor
|
Tests are passing with this PR. 🚀⚡ |
Collaborator
|
Thanks for the interop testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eclair only sets
batch_sizeandfunding_txidwhen its a batch larger than 1.Adjust how we send and what we expect to receive to match this.
Changelog-None