Skip to content

Avoid extra copy when unescaping JSON strings #8415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

whitslack
Copy link
Collaborator

Make use of rustyrussell/ccan#123 to avoid making an extra copy of escaped JSON strings just to unescape them.

Note that jsonrpc_command_add(…) no longer accepts usage strings containing invalid escape sequences. (Previously, it would quietly accept such a string without unescaping anything.)

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines. Not significant enough to warrant a changelog entry.
  • Tests have been added or modified to reflect the changes. Existing tests already check relevant functionality.
  • Documentation has been reviewed and updated as needed. Not a user-facing change.
  • Related issues have been listed and linked, including any that this PR closes. None relevant.

This avoids making an extra copy of the escaped string.

Note that jsonrpc_command_add() no longer accepts usage strings
containing invalid escape sequences. (Previously, it would quietly
accept such a string without unescaping anything.)

Changelog-None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant