Fix deprecated APIs handling and update glightning dependency #392
+8
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses two deprecation issues: 1. Apply changes from ElementsProject#336 - Add isDev parameter to CheckForDeprecatedApiConfig function - Skip deprecated API check in development mode - Remove --allow-deprecated-apis=true from test framework 2. Fix 'decodepay' deprecation error - Update glightning dependency to use PR ElementsProject/glightning#24 - This PR adds support for the new 'decode' RPC command - Maintains backward compatibility with older CLN versions The decodepay command was deprecated in CLN v24.11 in favor of the more general decode command. This change ensures compatibility with current and future CLN versions. Depends on: ElementsProject/glightning#24
YusukeShimizu
force-pushed
the
fix-deprecated-apis-and-decodepay
branch
from
e4a776c to
9690c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the '--allow-deprecated-apis=true' flag
from the CLightningNode initialization in the test framework.
This will increase the possibility of detecting problems before they occur, as support for the deprecated cln api is no longer available.
Fixes #232