Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbl-v0.1.1 #2493

Merged
merged 13 commits into from
Nov 16, 2024
Merged

kbl-v0.1.1 #2493

merged 13 commits into from
Nov 16, 2024

Conversation

whwang299
Copy link
Contributor

@baberabb
Copy link
Contributor

baberabb commented Nov 15, 2024

Thanks you for this! LGTM, except could you add an entry to lm_eval/tasks/README.md adding a description of the benchmarks like all the other tasks.

Also if you could add a readme to the task folder. Here's a template

@whwang299
Copy link
Contributor Author

whwang299 commented Nov 16, 2024

Hi @baberabb

I have added a README file for kbl task and modified lm_eval/tasks/README.md. Please let me know if any further work is required.

Thanks!

@baberabb
Copy link
Contributor

Looks great. Thanks!

@baberabb baberabb merged commit cbc31eb into EleutherAI:main Nov 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants