Fix reading custom task configs #3425
Merged
+25
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix the check for missing custom task config files. - Support glob pattern in given file paths. - Add deduplication for custom configs based on their content.
Contributor
|
Thank you! |
baberabb
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue number: #3424
This pull request rewrites the task loading part of function
cli_evaluatein__main__.pyin order to fix the check for missing custom task config files, as illustrated in the issue.A major goal of the fix is to remove as many duplicates as possible and to preserve the relative order, mimicing the behaviour of the original implementation when loading tasks provided by lm_eval.
Other changes along with the fix: